Drools 1180 Migrate QE tests upstream. #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 31, 2016 16:10
|
Looks good to me, +1. |
| then | ||
| $message1.getType(); // just to test that both messages are not null | ||
| $message2.getType(); | ||
| end |
There was a problem hiding this comment.
Nitpicking here -- some of the DRL files use spaces and some tabs. Would be great to unify that (and not use tabs :))
|
Looks good, just added few minor comments. |
|
+1 to merge once the build is green. |
Rikkola
pushed a commit
to Rikkola/drools
that referenced
this pull request
Jan 27, 2020
…he#802) This PR cover case when the rdrl file contains abbreviated conditions. It means condition like: p : Person(age != 18 && > 15 && < 25) This PR is reproducer for the issue RHBRMS-2854
dupliaka
pushed a commit
to dupliaka/drools
that referenced
this pull request
Apr 1, 2022
Signed-off-by: Ricardo Zanini <zanini@redhat.com>
cimbalek
pushed a commit
to cimbalek/incubator-kie-drools
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is third in a series of PRs that migrate some tests from QE regression test suite upstream (there will be more).
Migrated test classes that inherit from KieBasesTest class in QE regression test suite.