Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request to fix JBRULES-2976 #7

Closed
wants to merge 1 commit into from
Closed

Pull request to fix JBRULES-2976 #7

wants to merge 1 commit into from

Conversation

ljnelson
Copy link
Contributor

Hello; I'm new to git and github, so I apologize if I am inadvertently ignoring etiquette or making some other mistake.

JBRULES-2976 is a bug where the DefaultMarshaller--the default implementation of the Marshaller interface--does not use the ObjectMarshallingStrategy that is supplied at construction. It stores it, but never does anything with it. Instead, the strategy reachable from the supplied StatefulKnowledgeSession is used instead.

The patch/pull request here makes sure that the strategy is used appropriately.

All tests continue to pass in the drools-core module.

Please do let me know if this is an appropriate pull request, or what else I should do to get this fix in.

Thanks for all the work done on the Drools project.

Best,
Laird

@etirelli
Copy link
Contributor

etirelli commented May 9, 2011

Hi ljnelson, thanks for contributing. Your patch looks ok, so I will go ahead and merge it, but we always try to add a unit or integration test with every fix we do to the code. If you could provide such a test case would be awesome, as we can then avoid regressions in the future.

@etirelli etirelli closed this May 9, 2011
tarilabs referenced this pull request in tarilabs/drools Mar 27, 2017
@baldimir @etirelli
FEEL tests refactoring + some new corner cases (#7)
665d82a 
* Split FEELTest into separate test classes.

* Added some FEEL lists corner cases.

* Fixed typo.
tarilabs referenced this pull request in tarilabs/drools Mar 28, 2017
@baldimir @etirelli
FEEL tests refactoring + some new corner cases (#7)
669b3e5 
* Split FEELTest into separate test classes.

* Added some FEEL lists corner cases.

* Fixed typo.
tarilabs referenced this pull request in tarilabs/drools Mar 26, 2018
@baldimir @tarilabs
Add tests for different types of DMN validator input parameters (#7)
8bebe0b
mariofusco pushed a commit that referenced this pull request Mar 27, 2018
@tarilabs @mariofusco
DROOLS-2379 DROOLS-2380 DROOLS:2381 Validator fixes (#1839)
77b6d53 
* DROOLS-2379: DROOLS-2380: DROOLS:2381: adding test case and partial fix

* Fix DROOLS-2380 DROOLS-2381 (#6)

* Add tests for different types of DMN validator input parameters (#7)
evacchi added a commit to evacchi/drools that referenced this pull request Jun 25, 2018
@evacchi @tarilabs
DROOLS-1701 fixes to between and in (esp. with null handling) (a…
29c9378 
…pache#7)
mariofusco pushed a commit that referenced this pull request Jul 5, 2018
@evacchi @mariofusco
DROOLS-1701 fixes to between and in (esp. with null handling) (#7)
200b1ae
@mareknovotny mareknovotny mentioned this pull request Oct 31, 2019
Closed
dupliaka pushed a commit to dupliaka/drools that referenced this pull request Apr 1, 2022
@nmirasch @mswiderski
infinispan link fixed, 03_kogito-travel-agency readme update: images,…
06b9e62 
… kafka link and topic kogito-usertaskinstances-events added (apache#7)
dupliaka pushed a commit to dupliaka/drools that referenced this pull request Apr 1, 2022
@cristianonicolai
Merge pull request apache#7 from inodeman/KOGITO-1182
9a4607c 
KOGITO-1182 : Kogito Quick Starts Scripts / Kogito with Infinispan Update
dupliaka pushed a commit to dupliaka/drools that referenced this pull request Apr 1, 2022
@cristianonicolai
Merge pull request apache#7 from cristianonicolai/0.8.1
9be67ca 
KOGITO-1424 - Upgrade examples to Kogito 0.8.1
@radtriste radtriste mentioned this pull request Apr 18, 2023
Merged
tkobayas referenced this pull request in tkobayas/drools Oct 12, 2023
@mariofusco
Merge pull request #7 from tkobayas/RHDM-1993-7.x
0870b8e 
[7.x] [DROOLS-7493] [DROOLS-7497] executable model wrongly rewrites modify …
cimbalek pushed a commit to cimbalek/incubator-kie-drools that referenced this pull request Jan 19, 2024
@Kaitou786
[KOGITO-2293] - Setup job to cleanup old images nightlies (apache#7)
2c10159 
See: https://issues.redhat.com/browse/KOGITO-2293

Signed-off-by: TARUN KHANDELWAL <tarkhand@redhat.com>
mariofusco added a commit that referenced this pull request Feb 14, 2024
@tkobayas @mariofusco
@gitgabrio @lbenc135 @yurloc
[DROOLS-7591] Experiment branch : migrate a new drools-lsp parser int… (
3699d67 
#5682)

* add antlr4 based drl parser

* bump to drools 8.16.0.Beta

* improve node position discovery

* first c3 integration

* Module reorganization (#2)

* WIP

* Ignore directories

* Add debug. Minor modifications

* WIP

* Fix tests - add comments

* manage null ast nodes and fix failing test

* improve drl parser

* Fix basic completion (#4)

* Add Java grammar, fix DRL grammar, simplify token index calculation, remove template code

* Add ignored tokens to completion

Co-authored-by: livio <livio.bencik@mindsmiths.com>

* add constraints parsing

* - Added DRLParserWrapper to store errors using DRLErrorListener (#5)

- Added MiscDRLParserTest which is being ported from RuleParserTest to enhance coverage.

* Enhance test/grammar coverage. function import, global, exists, not (#6)

* Enhance test/grammar coverage. and, or, listExpression (#7)

* Enhance test/grammar coverage. matches, single quoted string, escape (#9)

- Introduced drlExpression, drlPrimary, drlLiteral, DRL_STRING_LITERAL

* Enhance test/grammar coverage. dialect, invalid lhs (#10)

* Enhance test/grammar coverage. keyword collision (#11)

- Add "DRL_" prefix for DRL keywords for clarification

* Enhance test/grammar coverage. function, attributes, consequence (#12)

* Enhance test/grammar coverage. function, attributes, consequence
- better getText preserving whitespaces
- resolving WARNs because of overlapping keywords

* - No need to declare duplicate keywords

* Enhance test/grammar coverage. OR, inline map (#13)

* OpenRewrite applied for junit5 and assertj (#14)

* Enhance test/grammar coverage. label, consequenceLocation, test refac… (#15)

* Enhance test/grammar coverage. label, consequenceLocation, test refactoring, assertj best practice

* - better test method names

* [DROOLS-7253] Review and improve drools-lsp parser Visitor design (#16)

* [DROOLS-7253] Review and improve drools-lsp parser Visitor design
- Remove currentConstructStack. Utilize return object instead.

* - Remove instance fields. Utilize return objects instead.

* [DROOLS-7270] Enhance test/grammar coverage : andRestriction, orRestriction (#4)

- Removed some unused cast

* [DROOLS-7271] Fully port RuleParserTest as MiscDRLParserTest with @disabled and priority comment (#10)

* [DROOLS-7285] Failed to parse and/or with parentheses in LHS (#15)

* [DROOLS-7286] Failed to parse binding with || (#21)

* [DROOLS-7287] Failed to parse comments in RHS (#23)

* [DROOLS-7287] Failed to parse comments in RHS

* - add rhs string check

* [DROOLS-7515] Parser : Accept plain text in RHS (#26)

* [DROOLS-7515] Parser : Accept plain text in RHS

* - Handle keyword token in RHS

* - Removed sysout

* - Revert statementKeywords. Instead, define DRL_END with newline or EOF

* - fix method name

* [DROOLS-7288] Failed to parse complex parentheses (#27)

* [DROOLS-7288] Failed to parse complex parentheses
- bump to 8.43.0.Final

* additional tests

* [DROOLS-7289] Implement accumulate (#28)

* [DROOLS-7296] Implement from entry-point (#30)

* [DROOLS-7297] Implement import accumulate (#29)

* [DROOLS-7290] Implement BigInteger literal, BigDecimal literal (#31)

* [DROOLS-7292] Implement eval (#32)

* [DROOLS-7293] Implement extends (#33)

* [DROOLS-7294] Implement forall (#34)

* [DROOLS-7298] Implement memberOf (#35)

* [DROOLS-7300] Implement positional constraint (#36)

* [DROOLS-7304] Implement temporal operators (#38)

- Also covers [DROOLS-7303] Implement sliding window

* [DROOLS-7301] Implement query (#37)

- Also partially fixes [DROOLS-7302] Implement semicolon delimiter

* [DROOLS-7295] Implement from collect (#39)

* [DROOLS-7305] Implement type declaration (#40)

- also covers [DROOLS-7291] Implement entry-point declaration
- also covers window declaration

* [DROOLS-7306] Implement unification (#41)

* [DROOLS-7306] Implement unification
- Also [DROOLS-7307] Parse attribute agenda-group

* [DROOLS-7308] Parse attribute without value
- Also [DROOLS-7309] Parse attribute with parentheses

* [DROOLS-7310] parse nested parentheses (#42)

* [DROOLS-7310] parse nested parentheses

* - Adding code commentes and explanations
- Adding more nested level tests

* [DROOLS-7577] drools-lsp : Add comments and explanations for drools-p… (#43)

* [DROOLS-7577] drools-lsp : Add comments and explanations for drools-parser

* removed syntax examples

* [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools (#44)

- Add some methods to call from drools code base

* Move necessary files without any additional modifications

* Update DRL6Expressions.g4 to ANTLR 4 (#47)

* Add DescrDumperTest and fix the expression parser grammar (#48)

* Add DescrDumperTest

* Fix it

* [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools
- New parser is migrated in drools-drl/drools-drl-parser with org.drools.drl10.parser package
- To enable the new parser, run `mvn test -PDRL10`
- At the moment, we get lots of test failures especially in drools-model/drools-model-codegen and drools-test-coverage/test-compiler-integration

* - License header
- Revert an inappropriate test edit
- Removed unnecessary profile
- Clarify unsupported methods
- Removed unnecessary bom dependency

---------

Co-authored-by: mariofusco <mario.fusco@gmail.com>
Co-authored-by: Gabriele Cardosi <gabriele.cardosi@gmail.com>
Co-authored-by: Livio Benčik <lbenc135@gmail.com>
Co-authored-by: livio <livio.bencik@mindsmiths.com>
Co-authored-by: Jiří Locker <jiri.locker@gmail.com>
mariofusco pushed a commit that referenced this pull request Feb 14, 2024
@tkobayas @mariofusco
Enhance test/grammar coverage. and, or, listExpression (#7)
37185cf
yesamer pushed a commit to yesamer/drools that referenced this pull request Mar 18, 2024
@github-actions @tkobayas
[KIE-766] exists and not don't work correctly with multiple constrain…
5fe5c9e 
…ts with BigDecimal (apache#5623) (#3) (apache#7)

Co-authored-by: Toshiya Kobayashi <toshiyakobayashi@gmail.com>
tkobayas added a commit that referenced this pull request Oct 11, 2024
@tkobayas @mariofusco
@gitgabrio @lbenc135 @yurloc
[DROOLS-7591] Experiment branch : migrate a new drools-lsp parser int… (
9da9b0e 
#5682)

* add antlr4 based drl parser

* bump to drools 8.16.0.Beta

* improve node position discovery

* first c3 integration

* Module reorganization (#2)

* WIP

* Ignore directories

* Add debug. Minor modifications

* WIP

* Fix tests - add comments

* manage null ast nodes and fix failing test

* improve drl parser

* Fix basic completion (#4)

* Add Java grammar, fix DRL grammar, simplify token index calculation, remove template code

* Add ignored tokens to completion

Co-authored-by: livio <livio.bencik@mindsmiths.com>

* add constraints parsing

* - Added DRLParserWrapper to store errors using DRLErrorListener (#5)

- Added MiscDRLParserTest which is being ported from RuleParserTest to enhance coverage.

* Enhance test/grammar coverage. function import, global, exists, not (#6)

* Enhance test/grammar coverage. and, or, listExpression (#7)

* Enhance test/grammar coverage. matches, single quoted string, escape (#9)

- Introduced drlExpression, drlPrimary, drlLiteral, DRL_STRING_LITERAL

* Enhance test/grammar coverage. dialect, invalid lhs (#10)

* Enhance test/grammar coverage. keyword collision (#11)

- Add "DRL_" prefix for DRL keywords for clarification

* Enhance test/grammar coverage. function, attributes, consequence (#12)

* Enhance test/grammar coverage. function, attributes, consequence
- better getText preserving whitespaces
- resolving WARNs because of overlapping keywords

* - No need to declare duplicate keywords

* Enhance test/grammar coverage. OR, inline map (#13)

* OpenRewrite applied for junit5 and assertj (#14)

* Enhance test/grammar coverage. label, consequenceLocation, test refac… (#15)

* Enhance test/grammar coverage. label, consequenceLocation, test refactoring, assertj best practice

* - better test method names

* [DROOLS-7253] Review and improve drools-lsp parser Visitor design (#16)

* [DROOLS-7253] Review and improve drools-lsp parser Visitor design
- Remove currentConstructStack. Utilize return object instead.

* - Remove instance fields. Utilize return objects instead.

* [DROOLS-7270] Enhance test/grammar coverage : andRestriction, orRestriction (#4)

- Removed some unused cast

* [DROOLS-7271] Fully port RuleParserTest as MiscDRLParserTest with @disabled and priority comment (#10)

* [DROOLS-7285] Failed to parse and/or with parentheses in LHS (#15)

* [DROOLS-7286] Failed to parse binding with || (#21)

* [DROOLS-7287] Failed to parse comments in RHS (#23)

* [DROOLS-7287] Failed to parse comments in RHS

* - add rhs string check

* [DROOLS-7515] Parser : Accept plain text in RHS (#26)

* [DROOLS-7515] Parser : Accept plain text in RHS

* - Handle keyword token in RHS

* - Removed sysout

* - Revert statementKeywords. Instead, define DRL_END with newline or EOF

* - fix method name

* [DROOLS-7288] Failed to parse complex parentheses (#27)

* [DROOLS-7288] Failed to parse complex parentheses
- bump to 8.43.0.Final

* additional tests

* [DROOLS-7289] Implement accumulate (#28)

* [DROOLS-7296] Implement from entry-point (#30)

* [DROOLS-7297] Implement import accumulate (#29)

* [DROOLS-7290] Implement BigInteger literal, BigDecimal literal (#31)

* [DROOLS-7292] Implement eval (#32)

* [DROOLS-7293] Implement extends (#33)

* [DROOLS-7294] Implement forall (#34)

* [DROOLS-7298] Implement memberOf (#35)

* [DROOLS-7300] Implement positional constraint (#36)

* [DROOLS-7304] Implement temporal operators (#38)

- Also covers [DROOLS-7303] Implement sliding window

* [DROOLS-7301] Implement query (#37)

- Also partially fixes [DROOLS-7302] Implement semicolon delimiter

* [DROOLS-7295] Implement from collect (#39)

* [DROOLS-7305] Implement type declaration (#40)

- also covers [DROOLS-7291] Implement entry-point declaration
- also covers window declaration

* [DROOLS-7306] Implement unification (#41)

* [DROOLS-7306] Implement unification
- Also [DROOLS-7307] Parse attribute agenda-group

* [DROOLS-7308] Parse attribute without value
- Also [DROOLS-7309] Parse attribute with parentheses

* [DROOLS-7310] parse nested parentheses (#42)

* [DROOLS-7310] parse nested parentheses

* - Adding code commentes and explanations
- Adding more nested level tests

* [DROOLS-7577] drools-lsp : Add comments and explanations for drools-p… (#43)

* [DROOLS-7577] drools-lsp : Add comments and explanations for drools-parser

* removed syntax examples

* [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools (#44)

- Add some methods to call from drools code base

* Move necessary files without any additional modifications

* Update DRL6Expressions.g4 to ANTLR 4 (#47)

* Add DescrDumperTest and fix the expression parser grammar (#48)

* Add DescrDumperTest

* Fix it

* [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools
- New parser is migrated in drools-drl/drools-drl-parser with org.drools.drl10.parser package
- To enable the new parser, run `mvn test -PDRL10`
- At the moment, we get lots of test failures especially in drools-model/drools-model-codegen and drools-test-coverage/test-compiler-integration

* - License header
- Revert an inappropriate test edit
- Removed unnecessary profile
- Clarify unsupported methods
- Removed unnecessary bom dependency

---------

Co-authored-by: mariofusco <mario.fusco@gmail.com>
Co-authored-by: Gabriele Cardosi <gabriele.cardosi@gmail.com>
Co-authored-by: Livio Benčik <lbenc135@gmail.com>
Co-authored-by: livio <livio.bencik@mindsmiths.com>
Co-authored-by: Jiří Locker <jiri.locker@gmail.com>
tkobayas added a commit that referenced this pull request Oct 11, 2024
@tkobayas
Enhance test/grammar coverage. and, or, listExpression (#7)
a21c580
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Oct 24, 2024
@tkobayas @mariofusco
@gitgabrio @lbenc135 @yurloc @rgdoliveira
[DROOLS-7591] Experiment branch : migrate a new drools-lsp parser int… (
d577bd6 
apache#5682)

* add antlr4 based drl parser

* bump to drools 8.16.0.Beta

* improve node position discovery

* first c3 integration

* Module reorganization (apache#2)

* WIP

* Ignore directories

* Add debug. Minor modifications

* WIP

* Fix tests - add comments

* manage null ast nodes and fix failing test

* improve drl parser

* Fix basic completion (apache#4)

* Add Java grammar, fix DRL grammar, simplify token index calculation, remove template code

* Add ignored tokens to completion

Co-authored-by: livio <livio.bencik@mindsmiths.com>

* add constraints parsing

* - Added DRLParserWrapper to store errors using DRLErrorListener (apache#5)

- Added MiscDRLParserTest which is being ported from RuleParserTest to enhance coverage.

* Enhance test/grammar coverage. function import, global, exists, not (apache#6)

* Enhance test/grammar coverage. and, or, listExpression (apache#7)

* Enhance test/grammar coverage. matches, single quoted string, escape (apache#9)

- Introduced drlExpression, drlPrimary, drlLiteral, DRL_STRING_LITERAL

* Enhance test/grammar coverage. dialect, invalid lhs (apache#10)

* Enhance test/grammar coverage. keyword collision (apache#11)

- Add "DRL_" prefix for DRL keywords for clarification

* Enhance test/grammar coverage. function, attributes, consequence (apache#12)

* Enhance test/grammar coverage. function, attributes, consequence
- better getText preserving whitespaces
- resolving WARNs because of overlapping keywords

* - No need to declare duplicate keywords

* Enhance test/grammar coverage. OR, inline map (apache#13)

* OpenRewrite applied for junit5 and assertj (apache#14)

* Enhance test/grammar coverage. label, consequenceLocation, test refac… (apache#15)

* Enhance test/grammar coverage. label, consequenceLocation, test refactoring, assertj best practice

* - better test method names

* [DROOLS-7253] Review and improve drools-lsp parser Visitor design (apache#16)

* [DROOLS-7253] Review and improve drools-lsp parser Visitor design
- Remove currentConstructStack. Utilize return object instead.

* - Remove instance fields. Utilize return objects instead.

* [DROOLS-7270] Enhance test/grammar coverage : andRestriction, orRestriction (apache#4)

- Removed some unused cast

* [DROOLS-7271] Fully port RuleParserTest as MiscDRLParserTest with @disabled and priority comment (apache#10)

* [DROOLS-7285] Failed to parse and/or with parentheses in LHS (apache#15)

* [DROOLS-7286] Failed to parse binding with || (apache#21)

* [DROOLS-7287] Failed to parse comments in RHS (apache#23)

* [DROOLS-7287] Failed to parse comments in RHS

* - add rhs string check

* [DROOLS-7515] Parser : Accept plain text in RHS (apache#26)

* [DROOLS-7515] Parser : Accept plain text in RHS

* - Handle keyword token in RHS

* - Removed sysout

* - Revert statementKeywords. Instead, define DRL_END with newline or EOF

* - fix method name

* [DROOLS-7288] Failed to parse complex parentheses (apache#27)

* [DROOLS-7288] Failed to parse complex parentheses
- bump to 8.43.0.Final

* additional tests

* [DROOLS-7289] Implement accumulate (apache#28)

* [DROOLS-7296] Implement from entry-point (apache#30)

* [DROOLS-7297] Implement import accumulate (apache#29)

* [DROOLS-7290] Implement BigInteger literal, BigDecimal literal (apache#31)

* [DROOLS-7292] Implement eval (apache#32)

* [DROOLS-7293] Implement extends (apache#33)

* [DROOLS-7294] Implement forall (apache#34)

* [DROOLS-7298] Implement memberOf (apache#35)

* [DROOLS-7300] Implement positional constraint (apache#36)

* [DROOLS-7304] Implement temporal operators (apache#38)

- Also covers [DROOLS-7303] Implement sliding window

* [DROOLS-7301] Implement query (apache#37)

- Also partially fixes [DROOLS-7302] Implement semicolon delimiter

* [DROOLS-7295] Implement from collect (apache#39)

* [DROOLS-7305] Implement type declaration (apache#40)

- also covers [DROOLS-7291] Implement entry-point declaration
- also covers window declaration

* [DROOLS-7306] Implement unification (apache#41)

* [DROOLS-7306] Implement unification
- Also [DROOLS-7307] Parse attribute agenda-group

* [DROOLS-7308] Parse attribute without value
- Also [DROOLS-7309] Parse attribute with parentheses

* [DROOLS-7310] parse nested parentheses (apache#42)

* [DROOLS-7310] parse nested parentheses

* - Adding code commentes and explanations
- Adding more nested level tests

* [DROOLS-7577] drools-lsp : Add comments and explanations for drools-p… (apache#43)

* [DROOLS-7577] drools-lsp : Add comments and explanations for drools-parser

* removed syntax examples

* [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools (apache#44)

- Add some methods to call from drools code base

* Move necessary files without any additional modifications

* Update DRL6Expressions.g4 to ANTLR 4 (apache#47)

* Add DescrDumperTest and fix the expression parser grammar (apache#48)

* Add DescrDumperTest

* Fix it

* [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools
- New parser is migrated in drools-drl/drools-drl-parser with org.drools.drl10.parser package
- To enable the new parser, run `mvn test -PDRL10`
- At the moment, we get lots of test failures especially in drools-model/drools-model-codegen and drools-test-coverage/test-compiler-integration

* - License header
- Revert an inappropriate test edit
- Removed unnecessary profile
- Clarify unsupported methods
- Removed unnecessary bom dependency

---------

Co-authored-by: mariofusco <mario.fusco@gmail.com>
Co-authored-by: Gabriele Cardosi <gabriele.cardosi@gmail.com>
Co-authored-by: Livio Benčik <lbenc135@gmail.com>
Co-authored-by: livio <livio.bencik@mindsmiths.com>
Co-authored-by: Jiří Locker <jiri.locker@gmail.com>
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Oct 24, 2024
@tkobayas @rgdoliveira
Enhance test/grammar coverage. and, or, listExpression (apache#7)
a30d771
mariofusco pushed a commit that referenced this pull request Nov 28, 2024
@pibizza
[incubator-kie-drools-6136] Migrate drools test coverage to JUnit5 - #7…
45c3b21 
… (#6175)

* More tests migrated

* Migrated tests to Junit5

* Migrated drools-core

* Migrated alphanetwork compiler
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Dec 2, 2024
@pibizza @rgdoliveira
[incubator-kie-drools-6136] Migrate drools test coverage to JUnit5 - a…
ebf1961 
…pache#7 (apache#6175)

* More tests migrated

* Migrated tests to Junit5

* Migrated drools-core

* Migrated alphanetwork compiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljnelson @etirelli