Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BXMSPROD-1892] Automated pull request backporting workflow #4863

Merged
merged 2 commits into from
Dec 14, 2022
Merged

[BXMSPROD-1892] Automated pull request backporting workflow #4863

merged 2 commits into from
Dec 14, 2022

Conversation

lampajr
Copy link
Contributor

@lampajr lampajr commented Dec 12, 2022

JIRA:

https://issues.redhat.com/browse/BXMSPROD-1892

referenced Pull Requests:

Added GitHub workflow to automate pull request backporting:

  • create backporting pull requests whenever a pull request (having one or more labels backport-<branch>) is successfully merged.

@mareknovotny
Copy link
Contributor

mareknovotny commented Dec 13, 2022

looks good, Could you please add also a guidance into PR template?

@lampajr
Copy link
Contributor Author

lampajr commented Dec 13, 2022

looks good, Could you please add also a guidance into PR template?

@mareknovotny added guidance here, do you agree? if so I will replicate it on all other repositories

Copy link
Contributor

@Ginxo Ginxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a new section about "What's backporting" and create a link to it from "How to backport a pull request to a different branch?" section. The rest LGTM

@lampajr
Copy link
Contributor Author

lampajr commented Dec 13, 2022

I would add a new section about "What's backporting" and create a link to it from "How to backport a pull request to a different branch?" section. The rest LGTM

@Ginxo Instead of adding a new section, wdyt if I directly add a simple definition of what a backporting is inside the How to backport a pull request to a different branch section? I think this way is cleaner and avoid to add too many stuff in the template itself.

Check this https://github.com/kiegroup/drools/pull/4863/files#diff-b2496e80299b8c3150b1944450bd81c622e04e13d15c411d291db0927d75fd6bR108

Copy link
Contributor

@Ginxo Ginxo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just check my proposal

.github/pull_request_template.md Outdated Show resolved Hide resolved
@mareknovotny mareknovotny merged commit 417b725 into apache:main Dec 14, 2022
@lampajr lampajr deleted the BXMSPROD-1892_backporting branch December 14, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants