-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DROOLS-7025] Move "efesto" inside "drools" repo #4490
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
dc8e9fd
[DROOLS-7025] Fixing ignores
gitgabrio 7b1d556
[DROOLS-7025] Fixing ignores - update README
gitgabrio 7f71abe
[DROOLS-7025] Fixing module name
gitgabrio af8afea
[DROOLS-7025] Fix README.md as per PR suggestion
gitgabrio 61e41c0
[DROOLS-7025] Fixing dependencies
gitgabrio 55b3aad
[DROOLS-7025] Disabling jacoco inside efesto/pmml-engine
gitgabrio 202ad4a
[DROOLS-7025] Disabling generate-aggregated-jacoco-report inside efes…
gitgabrio 7aa3f3a
[DROOLS-6918] Introducing Efesto. Build works. Tests not verified.
gitgabrio 1a0c1a2
[DROOLS-6918] Add MiningModelWithDrl.plantuml
gitgabrio a1f6b32
[DROOLS-6918] Cleanup - begun RuntimePmmlTest
gitgabrio 48206c9
[DROOLS-6918] Minor fix on pom names
gitgabrio 902f5c5
[DROOLS-7025] Fixing ignores
gitgabrio 04a1ac3
[DROOLS-7025] Fixing ignores - update README
gitgabrio 53eac98
[DROOLS-7025] Fixing module name
gitgabrio 7d1eafd
[DROOLS-7025] Fix README.md as per PR suggestion
gitgabrio 3361436
[DROOLS-7025] Fixing dependencies
gitgabrio f420eb4
[DROOLS-7025] Disabling jacoco inside efesto/pmml-engine
gitgabrio 9cd2bf2
[DROOLS-7025] Disabling generate-aggregated-jacoco-report inside efes…
gitgabrio 0f55949
[DROOLS-7025] Move efesto inside drools repo
gitgabrio 396e3de
[DROOLS-7025] Remove misleading sentence
gitgabrio a8d21bf
Update efesto/efesto-core/Readme.md
gitgabrio a505530
Update efesto/efesto-core/Readme.md
gitgabrio 90eeeab
[DROOLS-7025] Fix as per PR suggestion
gitgabrio 91b0335
[DROOLS-7025] Fixed as per PR suggestion
gitgabrio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,121 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<project xmlns="http://maven.apache.org/POM/4.0.0" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
<modelVersion>4.0.0</modelVersion> | ||
<parent> | ||
<groupId>org.kie</groupId> | ||
<artifactId>kie-core-bom</artifactId> | ||
<version>8.24.0-SNAPSHOT</version> | ||
<relativePath>../kie-core-bom/pom.xml</relativePath> | ||
</parent> | ||
|
||
<artifactId>efesto-bom</artifactId> | ||
<packaging>pom</packaging> | ||
|
||
<name>Efesto BOM (Bill Of Materials)</name> | ||
<description> | ||
Import this BOM in your dependencyManagement if you want to depend on Efesto framework. | ||
</description> | ||
|
||
<url>https://www.drools.org</url> | ||
|
||
<scm> | ||
<connection>scm:git:https://github.com/kiegroup/drools.git</connection> | ||
<developerConnection>scm:git:git@github.com:kiegroup/drools.git</developerConnection> | ||
<url>https://github.com/kiegroup/drools</url> | ||
</scm> | ||
<issueManagement> | ||
<system>jira</system> | ||
<url>https://issues.jboss.org/browse/DROOLS</url> | ||
</issueManagement> | ||
<developers> | ||
<developer> | ||
<name>All developers are listed on the team website</name> | ||
<url>http://www.drools.org/community/team.html</url> | ||
</developer> | ||
</developers> | ||
<contributors> | ||
<contributor> | ||
<name>All contributors are listed on the team website</name> | ||
<url>http://www.drools.org/community/team.html</url> | ||
</contributor> | ||
</contributors> | ||
<mailingLists> | ||
<mailingList> | ||
<name>setup</name> | ||
<subscribe>https://groups.google.com/forum/#!forum/drools-setup</subscribe> | ||
<unsubscribe>https://groups.google.com/forum/#!forum/drools-setup</unsubscribe> | ||
</mailingList> | ||
<mailingList> | ||
<name>usage</name> | ||
<subscribe>https://groups.google.com/forum/#!forum/drools-usage</subscribe> | ||
<unsubscribe>https://groups.google.com/forum/#!forum/drools-usage</unsubscribe> | ||
</mailingList> | ||
<mailingList> | ||
<name>development</name> | ||
<subscribe>https://groups.google.com/forum/#!forum/drools-development</subscribe> | ||
<unsubscribe>https://groups.google.com/forum/#!forum/drools-development</unsubscribe> | ||
</mailingList> | ||
</mailingLists> | ||
|
||
<!-- IMPORTANT: Do not declare any build things here! Declare them in kie-user-bom-parent. --> | ||
<build/> | ||
|
||
<dependencyManagement> | ||
<dependencies> | ||
<dependency> | ||
<groupId>org.kie</groupId> | ||
<artifactId>efesto-common-utils</artifactId> | ||
<version>${project.version}</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.kie</groupId> | ||
<artifactId>efesto-common-api</artifactId> | ||
<version>${project.version}</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.kie</groupId> | ||
<artifactId>efesto-compilation-manager-api</artifactId> | ||
<version>${project.version}</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.kie</groupId> | ||
<artifactId>efesto-compilation-manager-core</artifactId> | ||
<version>${project.version}</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.kie</groupId> | ||
<artifactId>efesto-runtime-manager-api</artifactId> | ||
<version>${project.version}</version> | ||
</dependency> | ||
<dependency> | ||
<groupId>org.kie</groupId> | ||
<artifactId>efesto-runtime-manager-core</artifactId> | ||
<version>${project.version}</version> | ||
</dependency> | ||
<!-- ENGINES --> | ||
<!-- External --> | ||
<!-- Kie --> | ||
<!-- <dependency>--> | ||
<!-- <groupId>org.kie</groupId>--> | ||
<!-- <artifactId>kie-api</artifactId>--> | ||
<!-- <version>${project.version}</version>--> | ||
<!-- </dependency>--> | ||
<!-- <dependency>--> | ||
<!-- <groupId>org.kie</groupId>--> | ||
<!-- <artifactId>kie-memory-compiler</artifactId>--> | ||
<!-- <version>${project.version}</version>--> | ||
<!-- </dependency>--> | ||
<!-- Logging --> | ||
<!-- Test --> | ||
<dependency> | ||
<groupId>org.kie</groupId> | ||
<artifactId>efesto-runtime-manager-api</artifactId> | ||
<version>${project.version}</version> | ||
<classifier>tests</classifier> | ||
</dependency> | ||
</dependencies> | ||
</dependencyManagement> | ||
|
||
</project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
!local/ | ||
*.bak |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
# Efesto | ||
------------------------- | ||
|
||
This module contains a rewriting of the `drools` framework, that is intended to be used to provide clear separation and composition for each compiler/runtime of the different engines that Drools project contains (Rules engine, DMN engine, PMML engine). | ||
The first step has been to include `efesto` as self-contained module inside `drools`. | ||
|
||
|
||
The main focus of this project is on: | ||
|
||
1. clear separation between "container" and "content" contexts; the "content" is represented by functionalities exposed | ||
by the compile-time and runtime; the "context" is the environment in which such functionalities are invoked ( | ||
see [architectural choices](https://docs.google.com/document/d/1n9rKcMh0qnP7R4DUb3xqanFZcN0q7SL8aBRoAdQDSH0) for more | ||
details) | ||
2. clear separation between compile-time and runtime | ||
3. uniform overall management of different models/engines | ||
|
||
Regarding the overall module organization/relationship, this project should follow the guidelines of the "Clean | ||
Architecture" principle. | ||
As per the design style, the microkernel-style will be featured, where each model/engine will represent a | ||
specific `plugin`. | ||
|
||
Each plugin should provide a `compilation` and a `runtime` component. | ||
|
||
The [documentation](./documentation) folder contains diagrams (PUML, Archimate), images, and other resources related to | ||
design/architectural choices. | ||
|
||
This effort can not be full-filled by a single person, since it involve decisions at every level and it will have an | ||
impact on the all `drools` codebase; everyone may be interested would be warmly welcomed for ideas, suggestions, | ||
criticism, contribution. | ||
|
||
|
||
ArchUnit | ||
======== | ||
ArchUnit has been introduced to enforce (as much as possible) some general architectural and design guidelines. | ||
|
||
See [official documentation](https://www.archunit.org/userguide/html/000_Index.html) and [maven plugin information](https://github.com/societe-generale/arch-unit-maven-plugin) for further details. | ||
|
||
JDepend | ||
======= | ||
JDepend is a tool that traverses Java class file directories and generates design quality metrics for each Java package. JDepend allows you to automatically measure the quality of a design in terms of its extensibility, reusability, and maintainability to manage package dependencies effectively. | ||
See [official documentation](http://clarkware.com/software/JDepend.html">http://clarkware.com/software/JDepend.html) | ||
for details. | ||
|
||
|
||
|
||
|
||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not create a new different bom but add the modules to the existing
kie-core-bom
. I don't expectefesto-bom
to be used directly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielezonca
For the moment being I think it is better to keep it "isolated" - there will be new modules add/renamed/removed, and make all this modifications inside that specific bom would ease keeping track.