[DROOLS-7017] "_this cannot be resolved" in LambdaExtractor when invo… #4461
Conversation
…lving a declaration in pattern
| private boolean hasNonGlobalDeclaration( ExpressionTyperContext expressionTyperContext ) { | ||
| return expressionTyperContext.getUsedDeclarations().stream() | ||
| .map( context::getDeclarationById ) | ||
| .anyMatch( optDecl -> optDecl.isPresent() && !optDecl.get().isGlobal() ); | ||
| private boolean hasDeclarationFromOtherPattern(ExpressionTyperContext expressionTyperContext) { | ||
| return expressionTyperContext.getUsedDeclarations() | ||
| .stream() | ||
| .map(context::getDeclarationById) | ||
| .anyMatch(optDecl -> { | ||
| if (optDecl.isPresent()) { | ||
| DeclarationSpec decl = optDecl.get(); | ||
| if (Boolean.FALSE.equals(decl.isGlobal()) && decl.getBelongingPatternDescr() != context.getCurrentPatternDescr()) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; | ||
| }); | ||
| } |
There was a problem hiding this comment.
The root problem is that exec-model tries to create a BetaIndex while non-exec-model creates AlphaConstraint in this case. In order to follow the non-exec-model logic,
https://github.com/tkobayas/drools/blob/7.x/drools-core/src/main/java/org/drools/core/rule/Pattern.java#L504
Not only checking global, but also checking if the declaration is declared inside the current Pattern. (See $rate in the test case)
|
Jenkins retest this |
| .anyMatch(optDecl -> { | ||
| if (optDecl.isPresent()) { | ||
| DeclarationSpec decl = optDecl.get(); | ||
| if (Boolean.FALSE.equals(decl.isGlobal()) && decl.getBelongingPatternDescr() != context.getCurrentPatternDescr()) { |
There was a problem hiding this comment.
I don't know why that isGlobal() method is returning a Boolean instead of a primitive boolean and I would really like to avoid the possibility of a 3-way logic, allowing a null there. If possible please replace that Boolean object with a primitive value inside the DeclarationSpec class. Regarding the condition in this statement I think anyway that, thanks to autounboxing you could however write !decl.isGlobal() here. If you needed to write Boolean.FALSE.equals(decl.isGlobal()) only to manage that possibility that isGlobal() could return a null, you should really review why this is happening and avoid it at any cost.
There was a problem hiding this comment.
Thank you, @mariofusco . I made the change suggested by SonarCloud but yes, changing Boolean to primitive boolean was the right fix. Thanks!
apache#4461) * [DROOLS-7017] "_this cannot be resolved" in LambdaExtractor when involving a declaration in pattern * - fix Boolean to primitive boolean
apache#4461) (apache#4471) * [DROOLS-7017] "_this cannot be resolved" in LambdaExtractor when involving a declaration in pattern * - fix Boolean to primitive boolean
apache#4461) * [DROOLS-7017] "_this cannot be resolved" in LambdaExtractor when involving a declaration in pattern * - fix Boolean to primitive boolean
#4461) * [DROOLS-7017] "_this cannot be resolved" in LambdaExtractor when involving a declaration in pattern * - fix Boolean to primitive boolean
apache#4461) * [DROOLS-7017] "_this cannot be resolved" in LambdaExtractor when involving a declaration in pattern * - fix Boolean to primitive boolean
#4461) * [DROOLS-7017] "_this cannot be resolved" in LambdaExtractor when involving a declaration in pattern * - fix Boolean to primitive boolean
…lving a declaration in pattern
Ports
This PR is for 7.x
for main -> https://github.com/kiegroup/drools/pull/4471
JIRA:
https://issues.redhat.com/browse/DROOLS-7017
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests
for a full downstream build
run_fdba compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native
for mandrel checks
Run native checks against Mandrel image
Please add comment: Jenkins run mandrel
for a specific mandrel check
Run native checks against Mandrel image
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] mandrel