[DROOLS-6683] improve ContextImpl constructor performance #4012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The (build) kogito-examples check has failed. Please check the logs. |
tkobayas
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
Thanks! Attached an async-profiler flamegraph of StatelessSessionConcurrentBenchmark with the PR to the JIRA ( https://issues.redhat.com/secure/attachment/12660221/after-pr-flame-cpu-StatelessSessionConcurrentBenchmark-thread1.svg ). Now ContextImpl.<impl> is much smaller.
Benchmark result also gets better.
Before PR
1 thread
Benchmark Mode Cnt Score Error Units
StatelessSessionConcurrentBenchmark.testStatelessKieSession thrpt 5 114576.824 ± 5141.367 ops/s
20 threads
Benchmark Mode Cnt Score Error Units
StatelessSessionConcurrentBenchmark.testStatelessKieSession thrpt 5 151469.510 ± 2266.503 ops/s
After PR
1 thread
Benchmark Mode Cnt Score Error Units
StatelessSessionConcurrentBenchmark.testStatelessKieSession thrpt 5 122195.505 ± 12761.116 ops/s
20 threads
Benchmark Mode Cnt Score Error Units
StatelessSessionConcurrentBenchmark.testStatelessKieSession thrpt 5 201325.006 ± 2998.486 ops/s
mariofusco
added a commit
to mariofusco/drools
that referenced
this pull request
Nov 15, 2021
(cherry picked from commit bf51954)
mariofusco
added a commit
that referenced
this pull request
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request
NOTE!: Double check the target branch for this PR.
The default is
mainso it will target Drools 8 / Kogito / Optaplanner 8.If this PR is not strictly related to drools and kogito project in
drools.git, it should probably target7.xas a branchPorts If a forward-port or a backport is needed, paste the forward port PR here
JIRA: https://issues.redhat.com/browse/DROOLS-6683