[DROOLS-6258] Fix drools-test-coverage for KieBaseTestConfiguration m…

[tkobayas]

…anipulation

JIRA:

https://issues.redhat.com/browse/DROOLS-6258

How to retest this PR or trigger a specific build:

• a pull request please add comment: Jenkins retest this

• a full downstream build please add comment: Jenkins run fdb

• a compile downstream build please add comment: Jenkins run cdb

• a full production downstream build please add comment: Jenkins execute product fdb

• an upstream build please add comment: Jenkins run upstream

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[tkobayas]

Hi @lucamolteni , @mariofusco ,
During the past test migration, I added setIdentity(), setStreamMode() to KieBaseTestConfiguration but it was my bad. KieBaseTestConfiguration has to be immutable. Luckily, we haven't hit issues in drools-test-coverage/test-compiler-integration in daily build (other than DROOLS-6255) but issues can be easily reproduced if you set surefire.forkCount=1 in pom.xml.

This fix will stabilize drools-test-coverage tests and I'll want to backport this to 7.52.x as well. Please reveiw, thanks!

[tkobayas]

"Linux - Compile Downstream Build " errors are not related to this PR.

[2021-04-02T07:30:15.665Z] [ERROR] Failed to execute goal on project google-sheets-workitem: Could not resolve dependencies for project org.jbpm.contrib:google-sheets-workitem:jar:7.53.0-SNAPSHOT: Could not transfer artifact com.google.http-client:google-http-client-jackson2:jar:1.23.0 from/to mirror-central (https://bxms-qe.rhev-ci-vms.eng.rdu2.redhat.com:8443/nexus/content/groups/kie-all/): /home/jenkins/.m2/repository/com/google/http-client/google-http-client-jackson2/1.23.0/google-http-client-jackson2-1.23.0.jar.part (No such file or directory) -> [Help 1]
[2021-04-02T07:30:15.665Z] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal on project google-sheets-workitem: Could not resolve dependencies for project org.jbpm.contrib:google-sheets-workitem:jar:7.53.0-SNAPSHOT: Could not transfer artifact com.google.http-client:google-http-client-jackson2:jar:1.23.0 from/to mirror-central (https://bxms-qe.rhev-ci-vms.eng.rdu2.redhat.com:8443/nexus/content/groups/kie-all/): /home/jenkins/.m2/repository/com/google/http-client/google-http-client-jackson2/1.23.0/google-http-client-jackson2-1.23.0.jar.part (No such file or directory)
[2021-04-02T07:30:15.665Z]     at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getDependencies (LifecycleDependencyResolver.java:269)
[2021-04-02T07:30:15.665Z]     at org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.resolveProjectDependencies (LifecycleDependencyResolver.java:147)
[2021-04-02T07:30:15.665Z]     at org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved (MojoExecutor.java:248)

[tkobayas]

for example, instead of modifying kieBaseTestConfiguration, get the expected kieBaseTestConfiguration instance (Stream mode while other properties are the same)