Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DROOLS-5697] example of 2 combined groupBy #3198

Closed
wants to merge 1 commit into from
+233 −5
Closed

[DROOLS-5697] example of 2 combined groupBy #3198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions drools-model/drools-canonical-model/src/main/java/org/drools/model/Drools.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,6 @@ public interface Drools extends DroolsEntryPoint {
void setFocus(String focus);

Channel getChannel(String name);

void logicalInsert(Object object);
}
5 changes: 5 additions & 0 deletions .../drools-model-compiler/src/main/java/org/drools/modelcompiler/consequence/DroolsImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,11 @@ public void insert(Object object, boolean dynamic) {
((InternalWorkingMemoryActions)workingMemory).insert(object, dynamic, getRule(), terminalNode);
}

@Override
public void logicalInsert(Object object) {
knowledgeHelper.insertLogical( object );
}

@Override
public RuleImpl getRule() {
return knowledgeHelper.getRule();
Expand Down
137 changes: 137 additions & 0 deletions ...ls-model/drools-model-compiler/src/test/java/org/drools/modelcompiler/AccumulateTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2548,4 +2548,141 @@ public void setEmployee(String employee) {
this.employee = employee;
}
}

@Test
public void testComposedGroupBy() {
// DROOLS-5697
String str =
"import java.util.*;\n" +
"import " + GroupResult.class.getCanonicalName() + ";\n" +
"import " + GroupKey.class.getCanonicalName() + ";\n" +
"import " + Person.class.getCanonicalName() + ";\n" +
"global Map results;\n" +

"rule R1 when\n" +
" Person( $initial : name.substring(0,3) )\n" +
" not( GroupKey(topic ==\"a\", key == $initial) )\n" +
"then\n" +
" insert( new GroupKey( \"a\", $initial ) );\n" +
"end\n" +
"\n" +
"rule R2 when\n" +
" $k: GroupKey( topic ==\"a\", $initial : key )\n" +
" not( Person( name.substring(0,3) == $initial ) )\n" +
"then\n" +
" delete( $k );\n" +
"end\n" +
"\n" +
"rule R3 when\n" +
" $groupKey : GroupKey( topic ==\"a\", $initial : key )\n" +
" accumulate (\n" +
" Person( $age: age, name.substring(0,3) == $initial );\n" +
" $sumOfAges : sum($age)\n" +
" )\n" +
"then\n" +
" insertLogical( new GroupResult($groupKey, $sumOfAges) );\n" +
"end\n" +

"rule R4 when\n" +
" GroupResult( topic ==\"a\", $initial : ((String)key).substring(0,2) )\n" +
" not( GroupKey( topic ==\"b\", key == $initial) )\n" +
"then\n" +
" insert( new GroupKey( \"b\", $initial ) );\n" +
"end\n" +
"\n" +
"rule R5 when\n" +
" $k: GroupKey( topic ==\"b\", $initial : key )\n" +
" not( GroupResult( topic ==\"a\", ((String)key).substring(0,2) == $initial ) )\n" +
"then\n" +
" delete( $k );\n" +
"end\n" +
"\n" +
"rule R6 when\n" +
" GroupKey( topic ==\"b\", $initial : key )\n" +
" accumulate (\n" +
" GroupResult( topic ==\"a\", $value: value, ((String)key).substring(0,2) == $initial );\n" +
" $maxOfValues : max($value)\n" +
" )\n" +
"then\n" +
" results.put($initial, $maxOfValues);\n" +
"end";

KieSession ksession = getKieSession(str);

Map results = new HashMap();
ksession.setGlobal( "results", results );

ksession.insert(new Person("Mark", 42));
ksession.insert(new Person("Edson", 38));
FactHandle meFH = ksession.insert(new Person("Mario", 45));
ksession.insert(new Person("Maciej", 39));
ksession.insert(new Person("Edoardo", 33));
FactHandle geoffreyFH = ksession.insert(new Person("Geoffrey", 35));
ksession.fireAllRules();

/*
* In the first groupBy:
* Mark+Mario become "(Mar, 87)"
* Maciej becomes "(Mac, 39)"
* Geoffrey becomes "(Geo, 35)"
* Edson becomes "(Eds, 38)"
* Edoardo becomes "(Edo, 33)"
*
* Then in the second groupBy:
* "(Mar, 87)" and "(Mac, 39)" become "(Ma, 87)"
* "(Eds, 38)" and "(Edo, 33)" become "(Ed, 38)"
* "(Geo, 35)" becomes "(Ge, 35)"
*/

assertEquals( 3, results.size() );
assertEquals( 87, results.get("Ma") );
assertEquals( 38, results.get("Ed") );
assertEquals( 35, results.get("Ge") );
results.clear();

ksession.delete( meFH );
ksession.fireAllRules();

// No Mario anymore, so "(Mar, 42)" instead of "(Mar, 87)".
// Therefore "(Ma, 42)".
assertEquals( 1, results.size() );
assertEquals( 42, results.get("Ma") );
results.clear();

// "(Geo, 35)" is gone.
// "(Mat, 38)" is added, but Mark still wins, so "(Ma, 42)" stays.
ksession.delete(geoffreyFH);
ksession.insert(new Person("Matteo", 38));
ksession.fireAllRules();

assertEquals( 1, results.size() );
assertEquals( 42, results.get("Ma") );
}

public static class GroupResult {
private final GroupKey key;
private final Object value;

public GroupResult( GroupKey key, Object value ) {
this.key = key;
this.value = value;
}

public GroupResult( String topic, Object key, Object value ) {
this.key = new GroupKey(topic, key);
this.value = value;
}

public String getTopic() {
return key.getTopic();
}

public Object getKey() {
return key.getKey();
}

public Object getValue() {
return value;
}
}
}
94 changes: 89 additions & 5 deletions drools-model/drools-model-compiler/src/test/java/org/drools/modelcompiler/GroupByTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@

package org.drools.modelcompiler;

import java.io.IOException;
import java.io.ObjectInput;
import java.io.ObjectOutput;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.HashMap;
Expand All @@ -29,7 +26,8 @@

import org.assertj.core.api.Assertions;
import org.drools.core.base.accumulators.CountAccumulateFunction;
import org.drools.core.reteoo.SubnetworkTuple;
import org.drools.core.base.accumulators.IntegerMaxAccumulateFunction;
import org.drools.core.base.accumulators.IntegerSumAccumulateFunction;
import org.drools.model.DSL;
import org.drools.model.Global;
import org.drools.model.Index;
Expand All @@ -52,7 +50,6 @@
import org.junit.Test;
import org.kie.api.KieBase;
import org.kie.api.runtime.KieSession;
import org.kie.api.runtime.rule.AccumulateFunction;
import org.kie.api.runtime.rule.FactHandle;

import static org.assertj.core.api.Assertions.assertThat;
Expand Down Expand Up @@ -755,4 +752,91 @@ public void testTwoExpressionsOnSecondPattern() {

assertThat(results).containsExactly(80, 75, 71);
}

@Test
public void testTwoGroupBy() {
// DROOLS-5697
Variable<String> var_$key = D.declarationOf(String.class);
Variable<Person> var_$p = D.declarationOf(Person.class);
Variable<Integer> var_$age = D.declarationOf(Integer.class);
Variable<Integer> var_$sumOfAges = D.declarationOf(Integer.class);

Rule rule1 = D.rule("R1").build(
D.groupBy(
D.pattern(var_$p).bind(var_$age, person -> person.getAge(), D.reactOn("age")),
var_$p, var_$key, person -> person.getName().substring(0, 3),
D.accFunction(IntegerSumAccumulateFunction::new, var_$age).as(var_$sumOfAges)),
D.on(var_$key, var_$sumOfAges)
.execute((drools, $key, $sumOfAges) -> drools.logicalInsert(new AccumulateTest.GroupResult("a", $key, $sumOfAges)))
);

Global<Map> var_results = D.globalOf(Map.class, "defaultpkg", "results");

Variable<AccumulateTest.GroupResult> var_$g1 = D.declarationOf(AccumulateTest.GroupResult.class);
Variable<Integer> var_$g1_value = D.declarationOf(Integer.class);
Variable<String> var_$key_2 = D.declarationOf(String.class);
Variable<Integer> var_$maxOfValues = D.declarationOf(Integer.class);

Rule rule2 = D.rule("R2").build(
D.groupBy(
D.pattern(var_$g1).expr( groupResult -> groupResult.getTopic().equals( "a" ) )
.bind(var_$g1_value, groupResult -> (Integer) groupResult.getValue(), D.reactOn("value")),
var_$g1, var_$key_2, groupResult -> ((String)groupResult.getKey()).substring(0, 2),
D.accFunction(IntegerMaxAccumulateFunction::new, var_$g1_value).as(var_$maxOfValues)),
D.on(var_$key_2, var_results, var_$maxOfValues)
.execute(($key, results, $maxOfValues) -> results.put($key, $maxOfValues))
);

Model model = new ModelImpl().addRule( rule1 ).addRule( rule2 ).addGlobal( var_results );
KieSession ksession = KieBaseBuilder.createKieBaseFromModel( model ).newKieSession();

Map results = new HashMap();
ksession.setGlobal( "results", results );

ksession.insert(new Person("Mark", 42));
ksession.insert(new Person("Edson", 38));
FactHandle meFH = ksession.insert(new Person("Mario", 45));
ksession.insert(new Person("Maciej", 39));
ksession.insert(new Person("Edoardo", 33));
FactHandle geoffreyFH = ksession.insert(new Person("Geoffrey", 35));
ksession.fireAllRules();

/*
* In the first groupBy:
* Mark+Mario become "(Mar, 87)"
* Maciej becomes "(Mac, 39)"
* Geoffrey becomes "(Geo, 35)"
* Edson becomes "(Eds, 38)"
* Edoardo becomes "(Edo, 33)"
*
* Then in the second groupBy:
* "(Mar, 87)" and "(Mac, 39)" become "(Ma, 87)"
* "(Eds, 38)" and "(Edo, 33)" become "(Ed, 38)"
* "(Geo, 35)" becomes "(Ge, 35)"
*/

assertEquals( 3, results.size() );
assertEquals( 87, results.get("Ma") );
assertEquals( 38, results.get("Ed") );
assertEquals( 35, results.get("Ge") );
results.clear();

ksession.delete( meFH );
ksession.fireAllRules();

// No Mario anymore, so "(Mar, 42)" instead of "(Mar, 87)".
// Therefore "(Ma, 42)".
assertEquals( 1, results.size() );
assertEquals( 42, results.get("Ma") );
results.clear();

// "(Geo, 35)" is gone.
// "(Mat, 38)" is added, but Mark still wins, so "(Ma, 42)" stays.
ksession.delete(geoffreyFH);
ksession.insert(new Person("Matteo", 38));
ksession.fireAllRules();

assertEquals( 1, results.size() );
assertEquals( 42, results.get("Ma") );
}
}