DROOLS-5766 : Issue while using LocalDateTime field reference in GRE #3195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Rikkola
commented
Oct 28, 2020
| @@ -537,8 +532,6 @@ static String adjustParam(final String dataType, | |||
| return param.substring(0, | |||
| param.length() - 1); | |||
| } | |||
| } else if (boundParams.containsKey(param)) { | |||
| return "=" + param; | |||
There was a problem hiding this comment.
The fix was to remove this bound parameters check. I could not find a single unit test hitting this spot, but I know this was added before the GRE moved to DRL based save format. The "=" here is not needed.
|
jenkins do fdb |
|
StackOverflow issue during in FDB: |
|
Should not be related. |
|
jenkins do fdb |
1 similar comment
|
jenkins do fdb |
jenkins do fdb |
|
Jenkins do fdb. |
|
@karreiro @jstastny-cz Finally green. |
jstastny-cz
approved these changes
Nov 13, 2020
|
@kiegroup/gatekeepers Hello, can I get a merge please. |
mareknovotny
approved these changes
Nov 18, 2020
tarilabs
pushed a commit
to tarilabs/drools
that referenced
this pull request
Jun 28, 2022
…Gs and Case/Showcase docs (apache#172) (apache#3195) * Bxmsdoc 6976 master - Single-source GSGs and Case/Showcase docs (apache#172) * BXMSDOC-6976 Single sourcing initial GSG BP and Case docs * BXMSDOC-6976-master Upstreamed both GSG for BP and Case docs. Will not push until I complete the GSG for DS. * BXMSDOC-6976 Pausing upstream effort for GSGs while researching the best approach to referencing drools topics from jBPM TOCs * BXMSDOC-6976 Upstream docs ready for review * BXMSDOC-6976 Updated based on DS QE review feedback * BXMSDOC-6976 Updated based on DS final comment * BXMSDOC-6976 Final updates based on Marian's QE input * BXMSDOC-6976 Final updates based on Marian's QE input * BXMSDOC-6976 reverted incorrect changes to topic ID and xrefs
nprentza
pushed a commit
to nprentza/drools
that referenced
this pull request
Jul 15, 2022
…Gs and Case/Showcase docs (apache#172) (apache#3195) * Bxmsdoc 6976 master - Single-source GSGs and Case/Showcase docs (apache#172) * BXMSDOC-6976 Single sourcing initial GSG BP and Case docs * BXMSDOC-6976-master Upstreamed both GSG for BP and Case docs. Will not push until I complete the GSG for DS. * BXMSDOC-6976 Pausing upstream effort for GSGs while researching the best approach to referencing drools topics from jBPM TOCs * BXMSDOC-6976 Upstream docs ready for review * BXMSDOC-6976 Updated based on DS QE review feedback * BXMSDOC-6976 Updated based on DS final comment * BXMSDOC-6976 Final updates based on Marian's QE input * BXMSDOC-6976 Final updates based on Marian's QE input * BXMSDOC-6976 reverted incorrect changes to topic ID and xrefs
tarilabs
pushed a commit
to tarilabs/drools
that referenced
this pull request
Aug 31, 2022
…Gs and Case/Showcase docs (apache#172) (apache#3195) * Bxmsdoc 6976 master - Single-source GSGs and Case/Showcase docs (apache#172) * BXMSDOC-6976 Single sourcing initial GSG BP and Case docs * BXMSDOC-6976-master Upstreamed both GSG for BP and Case docs. Will not push until I complete the GSG for DS. * BXMSDOC-6976 Pausing upstream effort for GSGs while researching the best approach to referencing drools topics from jBPM TOCs * BXMSDOC-6976 Upstream docs ready for review * BXMSDOC-6976 Updated based on DS QE review feedback * BXMSDOC-6976 Updated based on DS final comment * BXMSDOC-6976 Final updates based on Marian's QE input * BXMSDOC-6976 Final updates based on Marian's QE input * BXMSDOC-6976 reverted incorrect changes to topic ID and xrefs
tarilabs
pushed a commit
that referenced
this pull request
Sep 5, 2022
…Gs and Case/Showcase docs (#172) (#3195) * Bxmsdoc 6976 master - Single-source GSGs and Case/Showcase docs (#172) * BXMSDOC-6976 Single sourcing initial GSG BP and Case docs * BXMSDOC-6976-master Upstreamed both GSG for BP and Case docs. Will not push until I complete the GSG for DS. * BXMSDOC-6976 Pausing upstream effort for GSGs while researching the best approach to referencing drools topics from jBPM TOCs * BXMSDOC-6976 Upstream docs ready for review * BXMSDOC-6976 Updated based on DS QE review feedback * BXMSDOC-6976 Updated based on DS final comment * BXMSDOC-6976 Final updates based on Marian's QE input * BXMSDOC-6976 Final updates based on Marian's QE input * BXMSDOC-6976 reverted incorrect changes to topic ID and xrefs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA:
link
How to retest this PR or trigger a specific build:
a pull request please add comment: Jenkins retest this
a full downstream build please add comment: Jenkins run fdb
a compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream