[DROOLS-3368] Extend scenario runner to support DMN runtime #2194
Conversation
| .findFirst() | ||
| .orElseThrow(() -> new IllegalStateException("Cannot find a DMN model with resource=" + resourcePath)); | ||
| } | ||
| throw new IllegalStateException("This should not happen"); |
There was a problem hiding this comment.
I see this was just moved here, however please change the error message here. This doesn't say anything. E.g. "Cannot retrieve the model! Resource path or model name is not set properly."
There was a problem hiding this comment.
Changed to "Both resourcePath and namespace+modelName are not set, this should not happen". It is not possible that both are null, it is just to have an error if in the future the logic will change without update this method
| @Before | ||
| public void init() { | ||
| registryContext = new ContextImpl(); | ||
|
|
There was a problem hiding this comment.
Nitpicking (sorry:)): unnecessary empty line.
| try { | ||
| getDMNModelCommand.execute(registryContext); | ||
| fail(); | ||
| } catch (IllegalStateException ignored) { |
There was a problem hiding this comment.
Is this exception a correct state? This looks incorrect. This kind of catches in tests could hide potential bugs in the future.
There was a problem hiding this comment.
Migrated all these catch(IllegalStateException ignored) to Assertj with a constraint on the actual message
| try { | ||
| getDMNModelCommand.execute(registryContext); | ||
| fail(); | ||
| } catch (IllegalStateException ignored) { |
There was a problem hiding this comment.
Same as previous comment.
There was a problem hiding this comment.
Migrated all these catch(IllegalStateException ignored) to Assertj with a constraint on the actual message
* BXMSDOC-5425 Document DMN runtime listener prop * . * .
* BXMSDOC-5425 Document DMN runtime listener prop * . * .
NOTE: it cannot be tested via UI yet, only code + tests
@kkufova @Rikkola @gitgabrio
PR list
kiegroup/drools-wb#1027
https://github.com/kiegroup/drools/pull/2194
kiegroup/droolsjbpm-knowledge#353