GUVNOR-2980: Test scenarios do not show correct results #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manstis thanks for this PR, it seems good to me, anyway, this could solve also this problem: https://issues.jboss.org/browse/GUVNOR-2840 Am I right? |
|
Jenkins please retest this. |
|
@jomarko I assume it will fix that too; but will give it a try... |
|
@jomarko I can confirm with this fix https://issues.jboss.org/browse/GUVNOR-2840 is also fixed. |
|
@manstis thanks, good job! |
Rikkola
approved these changes
Apr 27, 2017
manstis
added a commit
to manstis/drools
that referenced
this pull request
Apr 27, 2017
(cherry picked from commit cd7e5ed)
manstis
added a commit
that referenced
this pull request
Apr 27, 2017
|
@manstis thanks! |
Rikkola
pushed a commit
to Rikkola/drools
that referenced
this pull request
Jan 27, 2020
…pache#1226) * [DROOLS-3969] Show selected cell on right click. Some SONAR fix * [DROOLS-3969] Reverting unrelated modifications. Improving tests
tarilabs
pushed a commit
to tarilabs/drools
that referenced
this pull request
Jun 28, 2022
nprentza
pushed a commit
to nprentza/drools
that referenced
this pull request
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.jboss.org/browse/GUVNOR-2980
As far as I could tell; the issue was that the Rule names expected to fire was "fully qualified names" whereas the information regarding which rules had actually fired was "simple names". I've changed
TestingEventListenerto record "fully qualified names".I've also tested the rule filtering (see here) and confirm it works as expected with "fully qualified names".