Fixed imports - the class didn't compile on jdk7. #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
baldimir
commented
Nov 11, 2016
- This is needed for running tests with jdk7.
psiroky
approved these changes
Nov 11, 2016
|
I'll also configure the animal-sniffer-plugin to scan also test sources, not just "main" sources, to avoid these kinds of issues in future. |
|
Thanks Petr! |
|
Unfortunately it seems that Someone even proposed a patch some time ago, but it probably never made it into the main sources: http://mojo.10943.n7.nabble.com/Fwd-animal-sniffer-for-maven-test-classes-td43156.html. There is nothing we can do right now, but if I find some time I'll see if I could add this feature into the plugin. |
cimbalek
pushed a commit
to cimbalek/incubator-kie-drools
that referenced
this pull request
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.