-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest mvel snapshot #1
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The one that receives only a string has being removed. Passing null for the expression is safe because mvel transform it to an "Unknown" expression in the exception message.
Closing this pull request as they fixed it directly meanwhile |
tarilabs
referenced
this pull request
in tarilabs/drools
Nov 26, 2015
I think I've noticed behavior change in KieScanner automatic-update since 6.1 -> 6.2 etc. and I would like to expose my current question below, please. Documentation[1] states: If the KieScanner finds, in the Maven repository, an updated version of the Kie project used by that KieContainer it automatically downloads the new version and triggers an incremental build of the new project. From this moment all the new KieBases and KieSessions created from that KieContainer will use the new project version. I think that current* behavior "From this moment on" actually is: 1- already existing KieBase, generated with getKieBase() : it does get automatically updated. This is the use case of named KieBase or default KieBase referenced from kmodule.xml 2- already existing KieBase, generated with newKieBase() : NOT automatically updated. This is the use case of KieBase created with "custom" KieBaseConfiguration settings and NOT referencing kmodule.xml 3- any KieBase generated after the KieScanner updated, with either getKieBase() or newKieBase() : directly the newer version, simple case, indeed as already mentioned in the documentation. Behavior for already existing KieSession depends on the underlying KieBase, so it make reference to the cases described here-above. To be fully explicit, when already existing KieSession was generated directly from KieContainer.newKieSession() is case #1 because it implies the default KieBase from kmodule.xml. My question is: - IF my statements are correct, which I checked earlier by JUnit test method below [2]: I think I will submit a PR with proposals for documentation clarifications: I think statement is missing to describe what happens to already existing KieSession and KieBase; from the current description I would have assumed only "new" stuff gets up-to-date, but (fortunately!) also some type of already-existing KieSession and KieBase gets automatically updated. - ELSE I'm wrong, meaning also case #2 should be automatically updated: I think I will submit via PR the JUnit test method below [2] with different assert values, because then case #2 we think actually demonstrate a bug. Can you tell me if it's one or the other, please? =) Thank you in advance for your feedback Ciao MM * (tested against master @ 6fcacdf, version 6.4.0-SNAPSHOT) [1] http://docs.jboss.org/drools/release/6.3.0.Final/drools-docs/html_single/index.html#d0e1390 Ref. https://groups.google.com/d/topic/drools-usage/XpFlRNjuc9c/discussion
mariofusco
referenced
this pull request
in mariofusco/drools
Feb 3, 2016
[DROOLS-1025] fix correctMemoryOnSinksChanged
tarilabs
referenced
this pull request
in tarilabs/drools
Mar 27, 2017
Test for loading example DMN XML. See http://www.omg.org/spec/DMN/20151101/ch11example.xml
tarilabs
referenced
this pull request
in tarilabs/drools
Mar 28, 2017
Test for loading example DMN XML. See http://www.omg.org/spec/DMN/20151101/ch11example.xml
etirelli
added a commit
that referenced
this pull request
May 7, 2017
* DROOLS-1535: adding compilation validation to DT input expressions * DROOLS-1535: Improving compilation to report unknown variables for decision table input expressions * DROOLS-1535: Improving compilation to report unknown variables for decision table input expressions * Drools 1535+tarilabs (#1) * Compile DT output to provide the users with compile time feedback on errors.
tarilabs
referenced
this pull request
in tarilabs/drools
Sep 8, 2017
Providing example help as requested.
manstis
pushed a commit
that referenced
this pull request
May 13, 2019
* [DROOLS-3838] BackEnd part import * [DROOLS-3838] Cleanup * Unify assertion framework (#1)
mariofusco
pushed a commit
that referenced
this pull request
Apr 12, 2021
* Initial commit * Print nodes by layer to try align left the LIA. * clean. * prepare for unknown nodes. * le bug correction. * Collecting at level 1-5 all the required nodes. * MANUAL experiment for subnetwork. * Trying to collate as possible the subnetwork. * Fixing breaking when complex subnetwork although same level nodes. * Fixing beta node constraints and classpath problems. * fixes. * Avoiding problem when using as a dependency (until merged upstream). * comsmetics on the not display. * with partitioning instead of vertical layering. * Still trying to merge the 2 approaches, for now it's a switch b/w them. * with the files. * Moar tests * latest imgs. * wrong loop nesting. * renaming to diagramRete() * Clean-up. * Adding browser FIREFOX, tested works. * Aligning with DROOLS-1024. * print debug vertical cluster flag in configuration * bugfix * oops commit * Bump junit from 4.12 to 4.13.1 (#1) Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md) - [Commits](junit-team/junit4@r4.12...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * realign * Migrate to graphviz-java * Use platform agnostic open file * main refactors without package renames * Refactor naming and package to drools-retediagram as agreed * subdir drools-retediagram * move into drools-retediagram * wire module into the build * dependency mgt * update logback for proper package Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
tiagobento
added a commit
to tiagobento/drools
that referenced
this pull request
Jul 27, 2021
dupliaka
referenced
this pull request
in dupliaka/drools
Apr 1, 2022
* DROOLS-3814 DMN Submarine Example on Quarkus * Allegedly external module problems fixed >0.13.1, upgrade to 0.13.3 * Add byName endpoint * License header * Downgrade to Quarkus 0.12.0 to test Jenkins CI pipeline * Try inherit 0.13.1 from submarine BOM (failed locally on 2019-05-16) * Revert and downgrade again to Quarkus 0.12 for Jenkins CI * Try with 0.13.1 and Jenkins CI * Downgrade to Quarkus 0.12.0 for Jenkins CI Error on Jenkins CI is: io.quarkus.bootstrap.BootstrapException: Failed to locate current project among the loaded local projects locally building fine. * Align to -runtimes kie-dmn-rest-utils rename * Implement review feedback * renaming submarine in kogito (#1) * Rework using Application injection * Working ok with generated endpoint for the model * cleanups * version alignment for the native maven profile (locally checked)
dupliaka
referenced
this pull request
in dupliaka/drools
Apr 1, 2022
dupliaka
referenced
this pull request
in dupliaka/drools
Apr 1, 2022
- quick fix to allow this to be opened in stunner
tarilabs
pushed a commit
that referenced
this pull request
Jul 4, 2022
nprentza
pushed a commit
to nprentza/drools
that referenced
this pull request
Jul 15, 2022
rgdoliveira
added a commit
to rgdoliveira/drools
that referenced
this pull request
Jan 16, 2024
Sync main branch with main-apache branch
cimbalek
pushed a commit
to cimbalek/incubator-kie-drools
that referenced
this pull request
Jan 19, 2024
* PLANNER-2474 optaplanner CI * PLANNER-2474 Added multijob buildchain option support (apache#1) * [PLANNER-2474] optaplanner-quickstarts added to branch_config.yaml * [PLANNER-2474] Jenkinsfile.buildchain * [PLANNER-2474] Jenkinsfile.buildchain getBuildChainActionInfo method * Update Jenkinsfile.buildchain Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * quarkus mapping * [PLANNER-2474] native and lts changes * Update Jenkinsfile.buildchain Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-native-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update pull-request-native-config.yaml * Update .ci/pull-request-native-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-native-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-lts-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-lts-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-native-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-native-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-native-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-lts-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-lts-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-lts-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update .ci/pull-request-native-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> * Update pull-request-lts-config.yaml * Update pull-request-lts-config.yaml * Planner 2474 (apache#2) * update * fix buildchain project env * Corrected quarkus git author * updated lts config * added LTS env var * fix * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Setup job specific envs (apache#3) * fix (apache#4) * Take optaplanner-quickstarts into account (apache#5) * Update dsl/seed/src/main/groovy/org/kie/jenkins/jobdsl/VersionUtils.groovy * Update dsl/seed/src/main/groovy/org/kie/jenkins/jobdsl/templates/KogitoJobTemplate.groovy * apply settingsXmlId * Update Jenkinsfile.buildchain * optaplanner-quickstarts mapping * Update branch.yaml * Apply suggestions from code review Co-authored-by: Enrique Mingorance Cano <ginxaco@gmail.com> * Take SonarCloud into account * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Apply suggestions from code review * Update Jenkinsfile.buildchain * updated config (apache#6) * updated config * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Update Jenkinsfile.buildchain * Apply suggestions from code review * Update pull-request-config.yaml * Update pull-request-lts-config.yaml * Update pull-request-native-config.yaml * Update pull-request-native-config.yaml * Update project-dependencies.yaml * Update project-dependencies-quarkus.yaml * Update project-dependencies-quarkus.yaml * Update project-dependencies-quarkus.yaml * Update project-dependencies.yaml * Update Jenkinsfile.buildchain * Update main.yaml * moved jenkinsfile.buildchain * Update KogitoJobTemplate.groovy * Update KogitoJobTemplate.groovy * Update Jenkinsfile.buildchain * Update .ci/project-dependencies-quarkus.yaml * Update project-dependencies-quarkus.yaml * Update project-dependencies-quarkus.yaml * Update .ci/pull-request-lts-config.yaml Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com> Co-authored-by: radtriste <tradisso@redhat.com>
cimbalek
pushed a commit
to cimbalek/incubator-kie-drools
that referenced
this pull request
Jan 19, 2024
* fix build-chain * updated build chain args * removed equal to * Update build-chain jenkinsfile for v3 (apache#1) --------- Co-authored-by: Tristan Radisson <tristan.radisson@gmail.com>
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Oct 24, 2024
…it5 - apache#1 (apache#6137) * Initial test migration * Migrated more unit tests * Migrated more unit tests * Fixed test * More tests migrated to junit5 * Fixed test
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have update the creation of CompileException.