clean up

apache · Apr 15, 2020 · 6554f3b · 6554f3b
1 parent 9df7ed4
commit 6554f3b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 12 deletions.
diff --git a/...ols-verifier-core/src/main/java/org/drools/verifier/core/checks/OverlappingRowsCheck.java b/...ols-verifier-core/src/main/java/org/drools/verifier/core/checks/OverlappingRowsCheck.java
@@ -49,8 +49,6 @@
 public class OverlappingRowsCheck
         extends PairCheck {
 
-//    public static Map<Integer, Integer> found = new HashMap<>();
-
     private final Index index;
 
     public OverlappingRowsCheck(final RuleInspector ruleInspector,
@@ -76,19 +74,10 @@ protected Severity getDefaultSeverity() {
 
     @Override
     public boolean check() {
-        // TODO dirty, but this should not run twice atm
         if (ruleInspector.getRowIndex() > other.getRowIndex()) {
             return hasIssues;
         }
-//        if (found.containsKey(other.getRowIndex()) && found.get(other.getRowIndex()).equals(ruleInspector.getRowIndex())) {
-//            return hasIssues;
-//        }
-
         hasIssues = ruleInspector.overlaps(other);
-//        if (hasIssues) {
-//            found.put(ruleInspector.getRowIndex(),
-//                      other.getRowIndex());
-//        }
         return hasIssues;
     }
 

diff --git a/...-dmn-validation/src/test/java/org/kie/dmn/validation/dtanalysis/SubsumptionRulesTest.java b/...-dmn-validation/src/test/java/org/kie/dmn/validation/dtanalysis/SubsumptionRulesTest.java
@@ -32,6 +32,7 @@
 import org.kie.dmn.validation.dtanalysis.model.Subsumption;
 
 import static org.hamcrest.Matchers.contains;
+import static org.hamcrest.Matchers.containsInAnyOrder;
 import static org.hamcrest.Matchers.hasSize;
 import static org.junit.Assert.assertThat;
 import static org.junit.Assert.assertTrue;
@@ -79,7 +80,7 @@ public void testSubsumptionRules() {
                                                                                                                              null))))));
         assertThat(overlaps, hasSize(2));
         // Assert OVERLAPs same values
-        assertThat(analysis.getOverlaps(), contains(overlaps.toArray()));
+        assertThat(analysis.getOverlaps(), containsInAnyOrder(overlaps.toArray()));
 
         // Subsumption count.
         assertThat(analysis.getSubsumptions(), hasSize(1));