This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
refactor: refactor create table procedure #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZuLiangWang
added a commit
to apache/horaedb
that referenced
this pull request
Dec 7, 2023
## Rationale Because the logic related to create table has been reconstructed in `horaemeta` apache/incubator-horaedb-meta#288, the results returned when reporting errors during create table have changed. Therefore, we need to correct the results of table creation in the integration test. ## Detailed Changes * Update create table result in integration test. ## Test Plan No need.
ZuLiangWang
added a commit
to ZuLiangWang/ceresmeta
that referenced
this pull request
Jan 10, 2024
## Rationale Due to the implementation problem of create table procedure, the current table creation error message of ceresmeta cannot be returned to ceresdb normally. We need to reconstruct it. ## Detailed Changes * Refactor create table procedure, make it could return error information normally. * Modify the error message returned in the service. ## Test Plan Pass CI.
ZuLiangWang
added a commit
to ZuLiangWang/ceresmeta
that referenced
this pull request
Jan 10, 2024
## Rationale Due to the implementation problem of create table procedure, the current table creation error message of ceresmeta cannot be returned to ceresdb normally. We need to reconstruct it. ## Detailed Changes * Refactor create table procedure, make it could return error information normally. * Modify the error message returned in the service. ## Test Plan Pass CI.
ShiKaiWi
pushed a commit
that referenced
this pull request
Jan 10, 2024
## Rationale Due to the implementation problem of create table procedure, the current table creation error message of ceresmeta cannot be returned to ceresdb normally. We need to reconstruct it. ## Detailed Changes * Refactor create table procedure, make it could return error information normally. * Modify the error message returned in the service. ## Test Plan Pass CI.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Due to the implementation problem of create table procedure, the current table creation error message of ceresmeta cannot be returned to ceresdb normally. We need to reconstruct it.
Detailed Changes
Test Plan
Pass CI.