This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
refactor: make create table idempotent #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baa64ee to
8d0ff8d
Compare
ShiKaiWi
reviewed
Jan 10, 2024
|
@ZuLiangWang After a bit of reviewing, I find the table id is not persisted in the |
After digging into the code not included by this PR, I find the table id will be fetched from the table meta data, so the second creation will use the same table id as before. |
ShiKaiWi
reviewed
Jan 10, 2024
## Rationale Currently the tests on the dev branch are not running properly. ## Detailed Changes * Cherry pick some changes on main branch. * Fix integration test. ## Test Plan Pass CI.
9c39c63 to
3426364
Compare
3426364 to
df98b9e
Compare
df98b9e to
71792f2
Compare
ShiKaiWi
reviewed
Jan 22, 2024
ShiKaiWi
reviewed
Jan 23, 2024
ShiKaiWi
approved these changes
Jan 23, 2024
ShiKaiWi
pushed a commit
to apache/horaedb
that referenced
this pull request
Jan 23, 2024
## Rationale Refer to: apache/incubator-horaedb-meta#286, since we implement idempotent table creation, the error message when repeatedly creating a table has changed, and the results of the integration test need to be modified. ## Detailed Changes * Update `create_tables.result` ## Test Plan No need.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Store the intermediate data for table creation through procedures to support idempotent table creation.
Detailed Changes
Test Plan
Pass all unit tests and integration tests.