This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
fix: drop partition table #231
Merged
ZuLiangWang
merged 6 commits into
apache:main
from
ZuLiangWang:fix_drop_patition_table_0914
Sep 20, 2023
Merged
fix: drop partition table #231
ZuLiangWang
merged 6 commits into
apache:main
from
ZuLiangWang:fix_drop_patition_table_0914
Sep 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZuLiangWang
force-pushed
the
fix_drop_patition_table_0914
branch
from
September 15, 2023 06:26
f4f307e
to
7a8dae0
Compare
Codecov Report
@@ Coverage Diff @@
## main #231 +/- ##
===========================================
+ Coverage 39.66% 60.55% +20.89%
===========================================
Files 34 43 +9
Lines 4213 5395 +1182
===========================================
+ Hits 1671 3267 +1596
+ Misses 2317 1716 -601
- Partials 225 412 +187
|
ZuLiangWang
force-pushed
the
fix_drop_patition_table_0914
branch
2 times, most recently
from
September 15, 2023 06:34
221633f
to
297033c
Compare
ShiKaiWi
reviewed
Sep 19, 2023
server/coordinator/procedure/ddl/droppartitiontable/drop_partition_table.go
Show resolved
Hide resolved
ShiKaiWi
reviewed
Sep 19, 2023
server/coordinator/procedure/ddl/droppartitiontable/drop_partition_table.go
Outdated
Show resolved
Hide resolved
ZuLiangWang
force-pushed
the
fix_drop_patition_table_0914
branch
from
September 20, 2023 02:22
8a39495
to
2faea58
Compare
ZuLiangWang
force-pushed
the
fix_drop_patition_table_0914
branch
from
September 20, 2023 02:31
2faea58
to
28ba30c
Compare
ShiKaiWi
reviewed
Sep 20, 2023
ShiKaiWi
approved these changes
Sep 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Fixed the issue where the table could not be deleted normally when the shard mapping relationship of the table did not exist.
What changes are included in this PR?
Are there any user-facing changes?
None.
How does this change test
Pass all unit tests and integration test.