Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

fix: wrong shard id when drop non-exist table #230

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

ShiKaiWi
Copy link
Member

@ShiKaiWi ShiKaiWi commented Sep 12, 2023

Which issue does this PR close?

Closes #

Rationale for this change

The shard is wrong when dropping a non-existent table.

What changes are included in this PR?

Throw an error when the table to drop is not found.

Are there any user-facing changes?

None.

How does this change test

Manually.

ZuLiangWang
ZuLiangWang previously approved these changes Sep 13, 2023
Copy link
Contributor

@ZuLiangWang ZuLiangWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #230 (e0d4d74) into main (7f1354e) will increase coverage by 21.20%.
Report is 33 commits behind head on main.
The diff coverage is 62.85%.

@@             Coverage Diff             @@
##             main     #230       +/-   ##
===========================================
+ Coverage   39.66%   60.86%   +21.20%     
===========================================
  Files          34       43        +9     
  Lines        4213     5359     +1146     
===========================================
+ Hits         1671     3262     +1591     
+ Misses       2317     1690      -627     
- Partials      225      407      +182     
Files Changed Coverage Δ
pkg/coderr/code.go 0.00% <ø> (ø)
server/cluster/metadata/types.go 0.00% <0.00%> (ø)
server/coordinator/procedure/util.go 0.00% <ø> (ø)
server/storage/meta.go 0.00% <ø> (ø)
server/storage/storage_impl.go 57.21% <0.00%> (-5.10%) ⬇️
server/member/watch_leader.go 40.62% <20.00%> (-2.71%) ⬇️
server/cluster/manager.go 38.96% <23.18%> (ø)
server/coordinator/factory.go 76.68% <30.76%> (+72.22%) ⬆️
.../operation/transferleader/batch_transfer_leader.go 33.80% <33.80%> (ø)
server/member/member.go 47.70% <47.82%> (-1.02%) ⬇️
... and 22 more

... and 1 file with indirect coverage changes

@ShiKaiWi ShiKaiWi force-pushed the fix-drop-table-wrong-shard-id branch from 81b784a to 50ebc00 Compare September 19, 2023 07:10
Copy link
Contributor

@ZuLiangWang ZuLiangWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZuLiangWang ZuLiangWang merged commit 07a50fc into apache:main Sep 19, 2023
@ShiKaiWi ShiKaiWi deleted the fix-drop-table-wrong-shard-id branch September 19, 2023 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants