This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
fix: wrong shard id when drop non-exist table #230
Merged
ZuLiangWang
merged 4 commits into
apache:main
from
ShiKaiWi:fix-drop-table-wrong-shard-id
Sep 19, 2023
Merged
fix: wrong shard id when drop non-exist table #230
ZuLiangWang
merged 4 commits into
apache:main
from
ShiKaiWi:fix-drop-table-wrong-shard-id
Sep 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZuLiangWang
previously approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ShiKaiWi
force-pushed
the
fix-drop-table-wrong-shard-id
branch
from
September 13, 2023 02:38
31f4b0a
to
c7a63d8
Compare
Codecov Report
@@ Coverage Diff @@
## main #230 +/- ##
===========================================
+ Coverage 39.66% 60.86% +21.20%
===========================================
Files 34 43 +9
Lines 4213 5359 +1146
===========================================
+ Hits 1671 3262 +1591
+ Misses 2317 1690 -627
- Partials 225 407 +182
|
ShiKaiWi
force-pushed
the
fix-drop-table-wrong-shard-id
branch
from
September 19, 2023 07:10
81b784a
to
50ebc00
Compare
ZuLiangWang
reviewed
Sep 19, 2023
ZuLiangWang
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
The shard is wrong when dropping a non-existent table.
What changes are included in this PR?
Throw an error when the table to drop is not found.
Are there any user-facing changes?
None.
How does this change test
Manually.