This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
refactor: support open shard concurrently #205
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #205 +/- ##
===========================================
+ Coverage 39.66% 60.15% +20.49%
===========================================
Files 34 42 +8
Lines 4213 5075 +862
===========================================
+ Hits 1671 3053 +1382
+ Misses 2317 1632 -685
- Partials 225 390 +165
|
8583a54
to
de5607e
Compare
5756832
to
3e3cc45
Compare
chunshao90
reviewed
Jun 28, 2023
server/coordinator/procedure/operation/transferleader/batch_transfer_leader_test.go
Outdated
Show resolved
Hide resolved
chunshao90
reviewed
Jun 28, 2023
c8f2161
to
8da5749
Compare
chunshao90
reviewed
Jul 3, 2023
server/coordinator/scheduler/static_topology_shard_scheduler.go
Outdated
Show resolved
Hide resolved
server/coordinator/scheduler/static_topology_shard_scheduler.go
Outdated
Show resolved
Hide resolved
8c41835
to
3f49fb8
Compare
3f49fb8
to
bed0dbb
Compare
chunshao90
reviewed
Jul 4, 2023
server/coordinator/procedure/operation/transferleader/batch_transfer_leader.go
Outdated
Show resolved
Hide resolved
server/coordinator/procedure/operation/transferleader/batch_transfer_leader.go
Show resolved
Hide resolved
a706f86
to
cc70934
Compare
chunshao90
reviewed
Jul 7, 2023
0ae3141
to
738afd4
Compare
chunshao90
reviewed
Jul 7, 2023
server/coordinator/procedure/operation/transferleader/batch_transfer_leader.go
Outdated
Show resolved
Hide resolved
29f37d2
to
604044a
Compare
chunshao90
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #173
Rationale for this change
As it mentioned in issue, we need to support open shard concurrently to improve failover performence.
What changes are included in this PR?
batch_transfer_leader
, it is used to open multiple shards concurrently in batches.Are there any user-facing changes?
None.
How does this change test
Pass all unit tests and integration tests.