Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

refactor: support open shard concurrently #205

Merged
merged 5 commits into from
Jul 7, 2023

Conversation

ZuLiangWang
Copy link
Contributor

@ZuLiangWang ZuLiangWang commented Jun 15, 2023

Which issue does this PR close?

Closes #173

Rationale for this change

As it mentioned in issue, we need to support open shard concurrently to improve failover performence.

What changes are included in this PR?

  • Add batch_transfer_leader, it is used to open multiple shards concurrently in batches.

Are there any user-facing changes?

None.

How does this change test

Pass all unit tests and integration tests.

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #205 (604044a) into main (7f1354e) will increase coverage by 20.49%.
The diff coverage is 57.23%.

@@             Coverage Diff             @@
##             main     #205       +/-   ##
===========================================
+ Coverage   39.66%   60.15%   +20.49%     
===========================================
  Files          34       42        +8     
  Lines        4213     5075      +862     
===========================================
+ Hits         1671     3053     +1382     
+ Misses       2317     1632      -685     
- Partials      225      390      +165     
Impacted Files Coverage Δ
pkg/coderr/code.go 0.00% <ø> (ø)
server/cluster/metadata/types.go 0.00% <0.00%> (ø)
server/coordinator/procedure/util.go 0.00% <ø> (ø)
server/storage/meta.go 0.00% <ø> (ø)
server/storage/storage_impl.go 57.21% <0.00%> (-5.10%) ⬇️
server/member/watch_leader.go 40.62% <20.00%> (-2.71%) ⬇️
server/cluster/manager.go 38.96% <23.52%> (ø)
server/coordinator/factory.go 76.68% <27.27%> (+72.22%) ⬆️
.../operation/transferleader/batch_transfer_leader.go 33.80% <33.80%> (ø)
server/member/member.go 47.39% <45.00%> (-1.32%) ⬇️
... and 19 more

... and 1 file with indirect coverage changes

@ZuLiangWang ZuLiangWang force-pushed the open_shard_concurrently branch 2 times, most recently from 8583a54 to de5607e Compare June 25, 2023 08:05
@ZuLiangWang ZuLiangWang marked this pull request as ready for review June 25, 2023 08:19
@ZuLiangWang ZuLiangWang force-pushed the open_shard_concurrently branch 3 times, most recently from 5756832 to 3e3cc45 Compare June 26, 2023 06:36
@ZuLiangWang ZuLiangWang force-pushed the open_shard_concurrently branch 2 times, most recently from c8f2161 to 8da5749 Compare July 3, 2023 07:04
@ZuLiangWang ZuLiangWang force-pushed the open_shard_concurrently branch from 8c41835 to 3f49fb8 Compare July 4, 2023 02:56
@ZuLiangWang ZuLiangWang force-pushed the open_shard_concurrently branch from 3f49fb8 to bed0dbb Compare July 4, 2023 08:40
@ZuLiangWang ZuLiangWang force-pushed the open_shard_concurrently branch from a706f86 to cc70934 Compare July 5, 2023 08:42
server/config/config.go Outdated Show resolved Hide resolved
@ZuLiangWang ZuLiangWang force-pushed the open_shard_concurrently branch from 0ae3141 to 738afd4 Compare July 7, 2023 02:57
@ZuLiangWang ZuLiangWang force-pushed the open_shard_concurrently branch from 29f37d2 to 604044a Compare July 7, 2023 07:48
Copy link
Contributor

@chunshao90 chunshao90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZuLiangWang ZuLiangWang merged commit 2200761 into apache:main Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open shards concurrently
2 participants