This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
refactor: refactor ddl procedures #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
684242a to
c94e502
Compare
c94e502 to
adeff11
Compare
ShiKaiWi
reviewed
Apr 13, 2023
server/coordinator/procedure/ddl/createpartitiontable/create_partition_table.go
Show resolved
Hide resolved
server/coordinator/procedure/ddl/createpartitiontable/create_partition_table.go
Show resolved
Hide resolved
server/coordinator/procedure/ddl/droppartitiontable/drop_partition_table.go
Outdated
Show resolved
Hide resolved
5491408 to
53f264e
Compare
53f264e to
0f86600
Compare
ShiKaiWi
reviewed
Apr 14, 2023
3df683c to
1879c24
Compare
ShiKaiWi
reviewed
Apr 14, 2023
server/coordinator/procedure/ddl/createpartitiontable/create_partition_table.go
Show resolved
Hide resolved
server/coordinator/procedure/ddl/createpartitiontable/create_partition_table.go
Outdated
Show resolved
Hide resolved
366f2b3 to
7cad134
Compare
ShiKaiWi
reviewed
Apr 14, 2023
server/coordinator/procedure/ddl/createpartitiontable/create_partition_table.go
Show resolved
Hide resolved
server/coordinator/procedure/ddl/createpartitiontable/create_partition_table.go
Outdated
Show resolved
Hide resolved
ShiKaiWi
reviewed
Apr 14, 2023
server/coordinator/procedure/ddl/createpartitiontable/create_partition_table.go
Show resolved
Hide resolved
ShiKaiWi
pushed a commit
that referenced
this pull request
Apr 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Adapt the ddl procedures to the current version of the procedure interface.
What changes are included in this PR?
CreateTableProcedure、DropTableProcedure、CreatePartitionTableProcedure、DropPartitionTableProcedureto the current version of the procedure interface.Are there any user-facing changes?
None.
How does this change test
Unit tests are currently not working properly and will be fixed in a subsequent pull request.