This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
feat: support drop partition table #126
Merged
ZuLiangWang
merged 9 commits into
apache:main
from
chunshao90:feat-drop-partition-table
Jan 11, 2023
Merged
feat: support drop partition table #126
ZuLiangWang
merged 9 commits into
apache:main
from
chunshao90:feat-drop-partition-table
Jan 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #126 +/- ##
==========================================
- Coverage 39.80% 39.62% -0.19%
==========================================
Files 29 33 +4
Lines 3432 4167 +735
==========================================
+ Hits 1366 1651 +285
- Misses 1882 2269 +387
- Partials 184 247 +63
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ZuLiangWang
reviewed
Jan 4, 2023
ZuLiangWang
reviewed
Jan 10, 2023
ZuLiangWang
reviewed
Jan 10, 2023
ZuLiangWang
reviewed
Jan 11, 2023
chunshao90
force-pushed
the
feat-drop-partition-table
branch
from
January 11, 2023 03:40
4caf272
to
e923c85
Compare
ZuLiangWang
previously approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ZuLiangWang
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #
Rationale for this change
Support drop partition table.
What changes are included in this PR?
Are there any user-facing changes?
Support drop partition table.
How does this change test
Add new test.