Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

feat: support drop partition table #126

Merged
merged 9 commits into from
Jan 11, 2023

Conversation

chunshao90
Copy link
Contributor

@chunshao90 chunshao90 commented Jan 3, 2023

Which issue does this PR close?

Closes #

Rationale for this change

Support drop partition table.

What changes are included in this PR?

  • Impl DropPartitionTableProcedure.
  • Add TestCreateAndDropPartitionTable.

Are there any user-facing changes?

Support drop partition table.

How does this change test

Add new test.

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Merging #126 (32d1562) into main (423ca15) will decrease coverage by 0.18%.
The diff coverage is 39.91%.

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   39.80%   39.62%   -0.19%     
==========================================
  Files          29       33       +4     
  Lines        3432     4167     +735     
==========================================
+ Hits         1366     1651     +285     
- Misses       1882     2269     +387     
- Partials      184      247      +63     
Impacted Files Coverage Δ
server/cluster/cluster.go 0.00% <0.00%> (ø)
server/cluster/manager.go 0.00% <0.00%> (ø)
server/cluster/table_manager.go 0.00% <0.00%> (ø)
server/cluster/topology_manager.go 0.00% <0.00%> (ø)
server/cluster/types.go 0.00% <ø> (ø)
server/coordinator/procedure/factory.go 0.00% <0.00%> (ø)
server/coordinator/procedure/manager_impl.go 0.00% <0.00%> (ø)
server/coordinator/procedure/scatter.go 65.00% <20.00%> (-1.92%) ⬇️
server/coordinator/procedure/util.go 38.88% <40.00%> (+0.17%) ⬆️
...er/coordinator/procedure/create_partition_table.go 45.22% <45.22%> (ø)
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chunshao90 chunshao90 marked this pull request as ready for review January 4, 2023 07:19
@chunshao90 chunshao90 force-pushed the feat-drop-partition-table branch from 4caf272 to e923c85 Compare January 11, 2023 03:40
ZuLiangWang
ZuLiangWang previously approved these changes Jan 11, 2023
Copy link
Contributor

@ZuLiangWang ZuLiangWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ZuLiangWang ZuLiangWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZuLiangWang ZuLiangWang merged commit 7555c19 into apache:main Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants