Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix][C++] Add a FinalizeS3 to adapt S3 destroy of arrow 12.0.0 #185

Closed
wants to merge 3 commits into from

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Jun 7, 2023

Signed-off-by: acezen qiaozi.zwb@alibaba-inc.com

Committed-by: acezen from Dev container

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to GraphAr?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Fixed #184

Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com>

Committed-by: acezen from Dev container
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

🎊 PR Preview 3a15d16 has been successfully built and deployed to https://alibaba-graphar-build-pr-185.surge.sh

🤖 By surge-preview

@acezen
Copy link
Contributor Author

acezen commented Jun 7, 2023

The memory still get leak in Debug mode, checking

acezen added 2 commits June 8, 2023 00:04
Committed-by: acezen from Dev container
Committed-by: acezen from Dev container
@acezen
Copy link
Contributor Author

acezen commented Jun 8, 2023

hi, @lixueclaire ,can you check the test_graph_info_load_from_s3 on your local environment?

@lixueclaire
Copy link
Contributor

hi, @lixueclaire ,can you check the test_graph_info_load_from_s3 on your local environment?

I have tried, but still got segmentation fault for this test under the build type of Release.

@lixueclaire
Copy link
Contributor

lixueclaire commented Jun 8, 2023

hi, @lixueclaire ,can you check the test_graph_info_load_from_s3 on your local environment?

Since the arrow version I use is 11.0, I modify your code to #if defined(ARROW_VERSION) && ARROW_VERSION >= 11000000, and then the test passed. Can you help to further check the versions in which finalize is required?

@@ -13,6 +13,8 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

#include <iostream>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this header file necessary?

@acezen
Copy link
Contributor Author

acezen commented Jun 9, 2023

Close the pull request since the arrow 12.0.0's workaround can not fix the aws sdk segmentfault. see #187

@acezen acezen closed this Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "test_graph_info_load_from_s3" failed under build type of Release
2 participants