-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix][C++] Add a FinalizeS3 to adapt S3 destroy of arrow 12.0.0 #185
Conversation
Signed-off-by: acezen <qiaozi.zwb@alibaba-inc.com> Committed-by: acezen from Dev container
🎊 PR Preview 3a15d16 has been successfully built and deployed to https://alibaba-graphar-build-pr-185.surge.sh ![]() 🤖 By surge-preview |
The memory still get leak in Debug mode, checking |
hi, @lixueclaire ,can you check the |
I have tried, but still got segmentation fault for this test under the build type of Release. |
Since the arrow version I use is 11.0, I modify your code to |
@@ -13,6 +13,8 @@ See the License for the specific language governing permissions and | |||
limitations under the License. | |||
*/ | |||
|
|||
#include <iostream> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this header file necessary?
Close the pull request since the arrow 12.0.0's workaround can not fix the aws sdk segmentfault. see #187 |
Signed-off-by: acezen qiaozi.zwb@alibaba-inc.com
Committed-by: acezen from Dev container
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to GraphAr?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Fixed #184