Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-6887][VL] Daily Update Velox Version (2025_02_12) #8711

Merged
merged 2 commits into from
Feb 12, 2025
Merged

[GLUTEN-6887][VL] Daily Update Velox Version (2025_02_12) #8711

merged 2 commits into from
Feb 12, 2025

Conversation

GlutenPerfBot
Copy link
Contributor

Upstream Velox's New Commits:

b71648f3e by Kevin Wilfong, fix: UserErrors leave json_parse in an invalid state (12308)
556851897 by Masha Basmanova, feat: Add convenience API to evalute constant expression (12306)
04bfdffcf by Pedro Eugenio Rocha Pedreira, feat(python): Make output-schema optional on tableWrite (12296)

[GLUTEN-6887][VL] Daily Update Velox Version (2025_02_12)
5f5b715 
Signed-off-by: glutenperfbot <glutenperfbot@intel-internal.com>
@github-actions GitHub Actions
Copy link

#6887

@zhouyuan
refine uniffile tests on downloading package
48e5aec 
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
@github-actions github-actions bot added the INFRA label Feb 12, 2025
@zhouyuan
Copy link
Contributor

@GlutenPerfBot benchmark

@GlutenPerfBot
Copy link
Contributor Author

ACK, will benchmark TPCH/DS on this pull request

zhouyuan
zhouyuan reviewed Feb 12, 2025
View reviewed changes
.github/workflows/velox_backend.yml
export JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk && \
export JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk
if [ ! -e "/opt/apache-uniffle-${{ matrix.uniffle }}-incubating-bin.tar.gz" ]; then
${WGET_CMD} https://archive.apache.org/dist/incubator/uniffle/${{ matrix.uniffle }}/apache-uniffle-${{ matrix.uniffle }}-incubating-bin.tar.gz -P /opt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackylee-ch FYI.

@GlutenPerfBot
Copy link
Contributor Author

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_8711_time.csv log/native_master_02_11_2025_fbb63d250b_time.csv difference percentage
q1 25.19 25.47 0.281 101.12%
q2 26.35 26.31 -0.042 99.84%
q3 33.02 32.86 -0.158 99.52%
q4 27.27 27.43 0.158 100.58%
q5 60.86 60.53 -0.330 99.46%
q6 9.01 9.00 -0.009 99.90%
q7 38.66 38.84 0.178 100.46%
q8 64.09 64.26 0.168 100.26%
q9 102.87 97.16 -5.713 94.45%
q10 44.46 43.94 -0.520 98.83%
q11 16.51 18.83 2.325 114.09%
q12 17.38 15.97 -1.407 91.90%
q13 26.65 25.04 -1.610 93.96%
q14 12.69 12.93 0.239 101.89%
q15 27.90 26.64 -1.259 95.49%
q16 12.59 12.78 0.197 101.57%
q17 78.95 78.45 -0.498 99.37%
q18 123.56 119.56 -4.001 96.76%
q19 17.85 13.44 -4.415 75.27%
q20 24.73 25.77 1.042 104.21%
q21 188.04 187.32 -0.725 99.61%
q22 11.86 10.47 -1.397 88.22%
total 990.49 973.00 -17.495 98.23%

@GlutenPerfBot
Copy link
Contributor Author

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_8711_time.csv log/native_master_02_11_2025_bb161098fa_time.csv difference percentage
q1 11.25 11.24 -0.016 99.85%
q2 9.89 12.01 2.118 121.42%
q3 3.29 3.39 0.099 103.02%
q4 52.01 52.52 0.500 100.96%
q5 9.12 7.93 -1.189 86.96%
q6 3.74 4.89 1.154 130.88%
q7 4.57 4.79 0.220 104.83%
q8 4.69 3.01 -1.684 64.11%
q9 17.57 14.65 -2.919 83.39%
q10 11.86 12.39 0.527 104.44%
q11 30.31 28.75 -1.565 94.84%
q12 2.87 1.63 -1.240 56.74%
q13 5.47 5.00 -0.468 91.45%
q14a 44.73 44.13 -0.597 98.67%
q14b 39.42 42.23 2.806 107.12%
q15 3.50 3.57 0.066 101.89%
q16 4.57 6.10 1.538 133.67%
q17 6.01 5.47 -0.540 91.01%
q18 7.28 8.71 1.432 119.67%
q19 3.30 3.83 0.529 116.02%
q20 2.07 1.94 -0.127 93.85%
q21 1.66 2.05 0.386 123.21%
q22 2.89 4.16 1.266 143.82%
q23a 63.20 61.53 -1.671 97.36%
q23b 75.27 71.77 -3.496 95.35%
q24a 71.60 71.43 -0.172 99.76%
q24b 66.97 69.17 2.197 103.28%
q25 6.38 5.15 -1.234 80.66%
q26 3.04 2.69 -0.356 88.29%
q27 2.22 2.22 0.004 100.17%
q28 17.57 16.94 -0.633 96.40%
q29 7.93 7.95 0.013 100.17%
q30 5.27 5.48 0.211 104.01%
q31 7.61 7.27 -0.346 95.46%
q32 1.79 2.19 0.395 122.04%
q33 3.48 4.26 0.782 122.47%
q34 3.02 3.84 0.821 127.21%
q35 7.22 6.37 -0.842 88.33%
q36 2.39 2.67 0.281 111.74%
q37 2.92 3.26 0.339 111.62%
q38 11.88 11.70 -0.178 98.50%
q39a 4.88 4.14 -0.741 84.82%
q39b 3.60 3.55 -0.051 98.59%
q40 3.37 3.89 0.515 115.26%
q41 0.69 0.72 0.031 104.54%
q42 0.85 0.92 0.064 107.48%
q43 2.06 2.99 0.926 144.96%
q44 6.83 5.86 -0.977 85.70%
q45 3.23 3.37 0.145 104.50%
q46 5.01 4.16 -0.859 82.87%
q47 9.74 9.56 -0.182 98.13%
q48 3.51 3.65 0.142 104.04%
q49 6.01 5.48 -0.532 91.15%
q50 17.51 17.39 -0.114 99.35%
q51 7.00 7.04 0.044 100.62%
q52 1.06 1.68 0.613 157.72%
q53 2.40 1.86 -0.541 77.46%
q54 6.00 5.66 -0.335 94.42%
q55 0.66 0.66 0.006 100.91%
q56 4.18 4.42 0.239 105.71%
q57 6.48 7.08 0.602 109.30%
q58 3.33 2.83 -0.500 85.00%
q59 4.47 4.40 -0.066 98.52%
q60 4.06 4.57 0.509 112.53%
q61 4.47 3.77 -0.703 84.29%
q62 2.88 3.61 0.729 125.29%
q63 1.42 1.28 -0.147 89.71%
q64 36.49 35.73 -0.757 97.93%
q65 11.41 11.72 0.314 102.75%
q66 3.58 2.79 -0.792 77.87%
q67 59.75 58.88 -0.870 98.54%
q68 2.93 2.98 0.055 101.88%
q69 6.10 5.15 -0.945 84.50%
q70 6.94 5.41 -1.529 77.97%
q71 6.83 5.12 -1.703 75.06%
q72 25.11 20.85 -4.262 83.03%
q73 3.29 2.40 -0.894 72.83%
q74 19.60 17.29 -2.309 88.22%
q75 26.96 23.40 -3.562 86.79%
q76 7.98 6.46 -1.528 80.86%
q77 2.87 2.85 -0.017 99.41%
q78 37.35 33.11 -4.231 88.67%
q79 3.65 3.39 -0.255 93.00%
q80 12.15 10.65 -1.504 87.62%
q81 7.39 8.01 0.622 108.42%
q82 5.97 5.64 -0.325 94.56%
q83 1.98 1.40 -0.577 70.77%
q84 2.65 2.68 0.026 100.99%
q85 6.66 6.18 -0.480 92.80%
q86 2.36 1.98 -0.375 84.09%
q87 12.05 11.41 -0.634 94.73%
q88 15.95 15.59 -0.358 97.75%
q89 2.27 2.28 0.003 100.12%
q90 2.01 1.95 -0.061 96.97%
q91 5.06 4.43 -0.624 87.65%
q92 2.03 2.15 0.118 105.83%
q93 23.96 23.79 -0.163 99.32%
q94 9.90 8.65 -1.246 87.41%
q9 59.07 59.93 0.859 101.46%
q5 2.51 2.86 0.353 114.08%
q96 12.33 10.96 -1.370 88.89%
q97 3.18 2.37 -0.811 74.49%
q98 5.30 5.25 -0.049 99.07%
q99 0.69 0.26 -0.438 36.87%
total 1213.84 1180.75 -33.088 97.27%

@zhouyuan zhouyuan merged commit b1858e2 into apache:main Feb 12, 2025
49 checks passed
@GlutenPerfBot
Copy link
Contributor Author

===== Performance report for TPCDS SF2000 with Velox backend, for reference only ====

query log/native_master_02_12_2025_time.csv log/native_master_02_11_2025_bb161098fa_time.csv difference percentage
q1 11.63 11.24 -0.393 96.62%
q2 12.20 12.01 -0.194 98.41%
q3 3.10 3.39 0.287 109.26%
q4 51.23 52.52 1.282 102.50%
q5 8.44 7.93 -0.518 93.87%
q6 3.92 4.89 0.975 124.89%
q7 4.90 4.79 -0.117 97.61%
q8 4.58 3.01 -1.572 65.67%
q9 16.89 14.65 -2.237 86.76%
q10 12.74 12.39 -0.355 97.21%
q11 27.45 28.75 1.293 104.71%
q12 2.13 1.63 -0.499 76.52%
q13 5.26 5.00 -0.256 95.13%
q14a 44.31 44.13 -0.178 99.60%
q14b 41.24 42.23 0.988 102.40%
q15 2.66 3.57 0.907 134.07%
q16 5.02 6.10 1.088 121.69%
q17 5.84 5.47 -0.368 93.69%
q18 6.82 8.71 1.885 127.61%
q19 3.30 3.83 0.533 116.15%
q20 2.32 1.94 -0.383 83.53%
q21 1.93 2.05 0.121 106.28%
q22 3.81 4.16 0.349 109.18%
q23a 60.72 61.53 0.810 101.33%
q23b 73.78 71.77 -2.007 97.28%
q24a 70.71 71.43 0.716 101.01%
q24b 67.93 69.17 1.237 101.82%
q25 5.47 5.15 -0.326 94.04%
q26 3.34 2.69 -0.649 80.54%
q27 2.47 2.22 -0.249 89.93%
q28 17.29 16.94 -0.359 97.92%
q29 7.82 7.95 0.125 101.60%
q30 5.11 5.48 0.366 107.15%
q31 7.32 7.27 -0.048 99.35%
q32 2.21 2.19 -0.028 98.74%
q33 4.49 4.26 -0.225 94.98%
q34 3.76 3.84 0.081 102.15%
q35 6.59 6.37 -0.215 96.74%
q36 2.39 2.67 0.279 111.64%
q37 3.43 3.26 -0.175 94.90%
q38 12.23 11.70 -0.526 95.70%
q39a 3.84 4.14 0.299 107.77%
q39b 3.77 3.55 -0.216 94.26%
q40 4.02 3.89 -0.137 96.59%
q41 0.63 0.72 0.092 114.58%
q42 0.77 0.92 0.144 118.62%
q43 2.20 2.99 0.783 135.55%
q44 6.70 5.86 -0.847 87.37%
q45 3.61 3.37 -0.241 93.32%
q46 4.39 4.16 -0.231 94.73%
q47 10.06 9.56 -0.499 95.04%
q48 3.68 3.65 -0.024 99.34%
q49 5.35 5.48 0.126 102.35%
q50 18.45 17.39 -1.052 94.29%
q51 7.77 7.04 -0.725 90.66%
q52 0.82 1.68 0.853 203.74%
q53 1.99 1.86 -0.127 93.60%
q54 5.67 5.66 -0.005 99.90%
q55 1.00 0.66 -0.333 66.53%
q56 3.68 4.42 0.736 119.98%
q57 6.42 7.08 0.656 110.22%
q58 2.78 2.83 0.053 101.90%
q59 4.18 4.40 0.218 105.20%
q60 4.87 4.57 -0.293 93.97%
q61 4.45 3.77 -0.677 84.78%
q62 2.92 3.61 0.689 123.58%
q63 1.51 1.28 -0.228 84.88%
q64 35.77 35.73 -0.038 99.89%
q65 11.38 11.72 0.344 103.03%
q66 3.37 2.79 -0.587 82.61%
q67 59.16 58.88 -0.279 99.53%
q68 2.94 2.98 0.048 101.63%
q69 5.16 5.15 -0.005 99.91%
q70 5.69 5.41 -0.276 95.15%
q71 5.08 5.12 0.041 100.81%
q72 21.36 20.85 -0.508 97.62%
q73 2.80 2.40 -0.405 85.55%
q74 17.36 17.29 -0.071 99.59%
q75 23.32 23.40 0.079 100.34%
q76 6.89 6.46 -0.438 93.64%
q77 2.94 2.85 -0.083 97.17%
q78 33.38 33.11 -0.267 99.20%
q79 3.68 3.39 -0.285 92.26%
q80 10.97 10.65 -0.324 97.05%
q81 6.60 8.01 1.409 121.36%
q82 5.69 5.64 -0.046 99.19%
q83 1.73 1.40 -0.329 80.94%
q84 2.97 2.68 -0.291 90.20%
q85 6.10 6.18 0.085 101.39%
q86 1.95 1.98 0.032 101.64%
q87 12.00 11.41 -0.590 95.08%
q88 14.59 15.59 1.003 106.88%
q89 2.35 2.28 -0.076 96.75%
q90 2.24 1.95 -0.293 86.94%
q91 3.57 4.43 0.863 124.19%
q92 1.65 2.15 0.499 130.23%
q93 24.71 23.79 -0.917 96.29%
q94 8.93 8.65 -0.280 96.86%
q9 58.89 59.93 1.041 101.77%
q5 1.97 2.86 0.888 144.98%
q96 11.34 10.96 -0.381 96.64%
q97 2.40 2.37 -0.036 98.49%
q98 5.33 5.25 -0.079 98.52%
q99 0.54 0.26 -0.285 47.28%
total 1181.13 1180.75 -0.380 99.97%

@GlutenPerfBot
Copy link
Contributor Author

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_02_12_2025_time.csv log/native_master_02_11_2025_fbb63d250b_time.csv difference percentage
q1 25.07 25.47 0.405 101.62%
q2 25.40 26.31 0.908 103.57%
q3 33.12 32.86 -0.259 99.22%
q4 27.71 27.43 -0.286 98.97%
q5 60.59 60.53 -0.065 99.89%
q6 9.07 9.00 -0.073 99.20%
q7 38.83 38.84 0.007 100.02%
q8 65.51 64.26 -1.254 98.09%
q9 106.79 97.16 -9.632 90.98%
q10 45.71 43.94 -1.773 96.12%
q11 16.55 18.83 2.280 113.77%
q12 16.33 15.97 -0.359 97.80%
q13 28.46 25.04 -3.420 87.98%
q14 13.66 12.93 -0.728 94.67%
q15 28.41 26.64 -1.769 93.77%
q16 13.98 12.78 -1.200 91.42%
q17 80.26 78.45 -1.808 97.75%
q18 120.92 119.56 -1.358 98.88%
q19 18.66 13.44 -5.221 72.02%
q20 26.08 25.77 -0.303 98.84%
q21 190.98 187.32 -3.667 98.08%
q22 12.50 10.47 -2.037 83.71%
total 1004.60 973.00 -31.610 96.85%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouyuan zhouyuan zhouyuan approved these changes

Assignees
No one assigned
Labels
BUILD INFRA VELOX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GlutenPerfBot @zhouyuan