-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Skip the velox download if velox_branch not exists #8682
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
works for me
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
When velox_home is specified and velox_repo:velox_branch doesn't exists, it means user prepared the customized Velox. We can skip the velox download and continue the build. It's user's responsibility to make sure the velox has correct version.
The PR served 2 purpose: