[VL] Use Velox's monolithic build #6731
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
3cc41f5 to
6543e9d
Compare
cpp/velox/CMakeLists.txt
Outdated
| ${VELOX_BUILD_PATH}/lib/libvelox.a) | ||
|
|
||
| if(BUILD_TESTS) | ||
| add_library(facebook::velox::dbgen STATIC IMPORTED) |
There was a problem hiding this comment.
@PHILO-HE For the testing libraries, they are still separate libraries, right?
There was a problem hiding this comment.
@xumingming, yes, these test libs are still separate.
cpp/velox/CMakeLists.txt
Outdated
| set_target_properties( | ||
| facebook::velox::dwio_common_test | ||
| PROPERTIES | ||
| IMPORTED_LOCATION |
There was a problem hiding this comment.
Please consider using a helper function to simply the code.
6543e9d to
85e8d0f
Compare
|
cool feature related to build! |
e528c20 to
0bd8c8d
Compare
0bd8c8d to
4dc86d3
Compare
|
@zhztheplayer, @xumingming, do you have any comments? |
What changes were proposed in this pull request?
Monolithic build was introduced into velox by facebookincubator/velox#9948. It will produce a unified velox lib, libvelox.a. With it, linking velox libs in Gluten becomes less complex and easier to maintain.
We also found Velox's test util libs are still separate. They are required when Gluten --build_tests=ON. In this case, we still keep linking these separate libs.
How was this patch tested?
CI.