-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Add 3 configs of spill #5088
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
Run Gluten Clickhouse CI |
To bypass the result mismatch issue of facebookincubator/velox#9219, you may set a very large MaxSpillRunRows and maxSpillFileSize |
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
val COLUMNAR_VELOX_MAX_SPILL_RUN_ROWS = | ||
buildConf("spark.gluten.sql.columnar.backend.velox.MaxSpillRunRows") | ||
.internal() | ||
.doc("The maximum row size of a single spill run") | ||
.bytesConf(ByteUnit.BYTE) | ||
.createWithDefaultString("12M") | ||
|
||
val COLUMNAR_VELOX_MAX_SPILL_BYTES = | ||
buildConf("spark.gluten.sql.columnar.backend.velox.MaxSpillBytes") | ||
.internal() | ||
.doc("The maximum file size of a query") | ||
.bytesConf(ByteUnit.BYTE) | ||
.createWithDefaultString("100G") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
MaxSpillRunRows-> maxSpillRunRows
MaxSpillBytes -> maxSpillBytes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for a nit. Thanks!
Run Gluten Clickhouse CI |
The 3 configs are missing in Gluten.