-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Zentao task worklogs #8298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94251ef
to
35e3b5f
Compare
35e3b5f
to
5dc4b4b
Compare
d4x1
reviewed
Feb 21, 2025
ApiClient: data.ApiClient, | ||
UrlTemplate: "tasks/{{ .Input.Id }}/estimate", | ||
Query: func(reqData *api.RequestData) (url.Values, errors.Error) { | ||
// According to the following resources, the worklogs API returns all worklogs without pagination |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these comments outdated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Has been corrected.
Please add a e2e test for the new tasks. @usharerose |
2bc89c3
to
753fc0b
Compare
d4x1
approved these changes
Feb 21, 2025
d4x1
added a commit
that referenced
this pull request
Feb 21, 2025
* feat: support Zentao task worklogs * feat: Zentao worklog tool layer migration * fix: dict as raw data instead of slice * test: e2e for zentao task worklogs * fix: compatibility when no account available --------- Co-authored-by: Lynwee <1507509064@qq.com>
d4x1
added a commit
that referenced
this pull request
Feb 21, 2025
* feat: support Zentao task worklogs (#8298) * feat: support Zentao task worklogs * feat: Zentao worklog tool layer migration * fix: dict as raw data instead of slice * test: e2e for zentao task worklogs * fix: compatibility when no account available --------- Co-authored-by: Lynwee <1507509064@qq.com> * fix: go lint and import errors (#8300) * fix: import errors * fix: go fmt issues * fix: missing quote * fix: skip float accuracy issues * fix(zentao): fix e2e tests --------- Co-authored-by: Chaojie Yan <chaojie.yan@merico.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/plugins
This issue or PR relates to plugins
needs-cherrypick-v1.0
pr-type/feature-development
This PR is to develop a new feature
size:XL
This PR changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
make plugin
zentao
support worklogsDoes this close any open issues?
N/A
Screenshots
Other Information
N/A