Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add sonarqube scope and fix some models #4369

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

abeizn
Copy link
Contributor

@abeizn abeizn commented Feb 9, 2023

Summary

feat: add sonarqube scope and fix some models

Does this close any open issues?

part of #2305

Screenshots

  1. /plugins/sonarqube/connections/{connectionId}/scopes [PUT]
    image

  2. /plugins/sonarqube/connections/{connectionId}/scopes/ [GET]
    image

  3. /plugins/sonarqube/connections/{connectionId}/scopes/{projectKey} [GET]
    image

  4. /plugins/sonarqube/connections/{connectionId}/scopes/{projectKey} [PATCH]
    image

Other Information

Any other information that is important to this PR.

FileLanguage string `json:"fileLanguage"`
CodeSmells int `json:"codeSmells"`
SqaleIndex string `json:"sqaleIndex"`
SqaleRating string `json:"sqaleRating"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you change this model?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

Copy link
Contributor

@warren830 warren830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warren830 warren830 merged commit d2815d5 into apache:main Feb 9, 2023
@warren830 warren830 deleted the feat-sonarqube-scope branch February 9, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants