-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature-1883][Plugin] Implement the gitee plugin #2195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job! Only a little minor bugs need to be fixed
func ConvertCommit(commit *GiteeApiCommitResponse) (*models.GiteeCommit, error) { | ||
giteeCommit := &models.GiteeCommit{ | ||
Sha: commit.Sha, | ||
AuthorId: commit.Author.Id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i will fixed it
} | ||
|
||
func CollectApiPullRequestReviews(taskCtx core.SubTaskContext) error { | ||
db := taskCtx.GetDb() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i will fixed it
e95582b
to
b1cc18f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Implement the gittee plugin,
Does this close any open issues?
close #1883
Screenshots
Other Information
Any other information that is important to this PR.