Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-1883][Plugin] Implement the gitee plugin #2195

Merged
merged 10 commits into from
Jun 18, 2022

Conversation

SnowMoon-Dev
Copy link
Contributor

@SnowMoon-Dev SnowMoon-Dev commented Jun 15, 2022

Summary

Implement the gittee plugin,

Does this close any open issues?

close #1883

Screenshots

image

Other Information

Any other information that is important to this PR.

@SnowMoon-Dev SnowMoon-Dev changed the title [Feature-1883][Plugin] Implement gittee plugin [Feature-1883][Plugin] Implement the gittee plugin Jun 15, 2022
@hezyin hezyin changed the title [Feature-1883][Plugin] Implement the gittee plugin [Feature-1883][Plugin] Implement the gitee plugin Jun 15, 2022
@warren830
Copy link
Contributor

I tried to run all tasks locally, but I got the following error:
image

Copy link
Contributor

@warren830 warren830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job! Only a little minor bugs need to be fixed

func ConvertCommit(commit *GiteeApiCommitResponse) (*models.GiteeCommit, error) {
giteeCommit := &models.GiteeCommit{
Sha: commit.Sha,
AuthorId: commit.Author.Id,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to run all tasks locally, but I got the following error:
image
I think this is the root clause, commit.Author might be nil

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i will fixed it

}

func CollectApiPullRequestReviews(taskCtx core.SubTaskContext) error {
db := taskCtx.GetDb()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got not found project error when collecting pr_review
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i will fixed it

@SnowMoon-Dev SnowMoon-Dev requested a review from warren830 June 18, 2022 09:04
Copy link
Contributor

@warren830 warren830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warren830 warren830 merged commit 5f0804b into apache:main Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a plugin for Gitee
2 participants