Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGNITE-19652 Adapt to DirectByteBuffer ctor changes in JDK 21 #10764

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Jun 5, 2023

Signature has changed in openjdk/jdk@a56598f

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

@wendigo
Copy link
Contributor Author

wendigo commented Jun 6, 2023

Ping @NSAmelchev @alex-plekhanov

@NSAmelchev
Copy link
Contributor

Hello, @wendigo.
Please, fix the codestyle.
I suggest writing to the dev list to ask for help with running CI on a new JDK.

@wendigo wendigo force-pushed the serafin/bytebuffer-jdk21 branch from a43a839 to b3a8f15 Compare June 7, 2023 20:43
@wendigo wendigo requested a review from NSAmelchev June 7, 2023 20:50
@wendigo wendigo force-pushed the serafin/bytebuffer-jdk21 branch from b3a8f15 to f1fd48c Compare June 7, 2023 20:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wendigo
Copy link
Contributor Author

wendigo commented Jun 12, 2023

@NSAmelchev ping

@ptupitsyn ptupitsyn merged commit fc51f0e into apache:master Jun 15, 2023
@wendigo wendigo deleted the serafin/bytebuffer-jdk21 branch June 15, 2023 08:46
@wendigo
Copy link
Contributor Author

wendigo commented Jun 16, 2023

@ptupitsyn do you happen to know when the next minor release is happening?

@ptupitsyn
Copy link
Contributor

@wendigo there is no set date, but I would expect it by the end of the year.

@wendigo
Copy link
Contributor Author

wendigo commented Jun 16, 2023

@ptupitsyn that’s too late for us in Trino. I guess that I’ll need to patch it somehow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants