Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TableMetadata last_updated_ms not increased for all operations #978

Merged

Conversation

c-thiel
Copy link
Collaborator

@c-thiel c-thiel commented Feb 19, 2025

Currently we increase the last_updated_ms timestamp only if a snapshot was added.
Java always updates this timestamp, also if i.e. only Properties where added..

Trino has a catalog integration test that validates this - which we failed due to this.

This PR ensures that last_updated_ms is always updated for builds.

Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @c-thiel for fixing this!

@liurenjie1024 liurenjie1024 merged commit c6cf0e9 into apache:main Feb 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants