-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata table scans as streams #870
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c6514d
to
359bbf2
Compare
rshkv
commented
Jan 3, 2025
Xuanwo
reviewed
Jan 7, 2025
5960673
to
0cf2b36
Compare
0cf2b36
to
27a5068
Compare
@liurenjie1024, rebased. We don't strictly need this before merging #863. But would be nice to agree on some stylistic "patterns" for async streams (e.g. using |
d504fc9
to
8283288
Compare
Xuanwo
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rshkv for working on this, let's move.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the metadata table APIs to have
scan()
return streams instead of a singleRecordBatch
.Context for this is #863 (comment), where we're adding a metadata table for which we need to read multiple files. @liurenjie1024 suggested we better consume those as stream.
I'm splitting out to discuss the API change separately, even though the existing metadata tables
snapshots
andmanifests
only read a single file we're just returning async streams of a single record batch.cc @liurenjie1024 @Xuanwo