Homepage added to Cargo.toml

[hiirrxnn]

Let me know if this works !

[Fokko]

@hiirrxnn I think we want to add the website to each of the Cargo.toml in each of the crates, for example here:

iceberg-rust/crates/catalog/hms/Cargo.toml

Lines 23 to 27 in b703146

	categories = ["database"]
	description = "Apache Iceberg Hive Metastore Catalog Support"
	repository = "https://github.com/apache/iceberg-rust"
	license = "Apache-2.0"
	keywords = ["iceberg", "hive", "catalog"]

[hiirrxnn]

Is it alright now ? I've done it in the way mentioned by the doc referenced here . Let me know if something has to be changed here .

[liurenjie1024]

Hi, @hiirrxnn There is another approach for this, please follow these steps:

1. You can add the home page info in Cargo.toml of workspace.
2. Then in Cargo.toml of each package, set the filed value to homepage = {workspace = true}.

Here is a great example from cargo: https://doc.rust-lang.org/cargo/reference/workspaces.html#the-package-table

This way we don't need to repeat same thing for each package.

[hiirrxnn]

I have done that ! Is that what you meant ? Let me know if there's something wrong !

[liurenjie1024]

I have done that ! Is that what you meant ? Let me know if there's something wrong !

Yeah, exactly, thanks!

There are also several fields which are shared among all packages in a workspace:

1. version
2. edition
3. license
4. repository

Do you want to modify them together or we can do it in later prs, it's up to you.

[hiirrxnn]

I will start doing those other packages asap , but i think i should do that in a different pr as too much modified code in one pr might not be ideal . Please tell me how you think about this , otherwise i can do it in this pr as well !

[hiirrxnn]

Should i follow the exact same approach for all of them , in essence referring them from workspace Cargo.toml?

[liurenjie1024]

Should i follow the exact same approach for all of them , in essence referring them from workspace Cargo.toml?

Yes, thanks!

[liurenjie1024]

I will start doing those other packages asap , but i think i should do that in a different pr as too much modified code in one pr might not be ideal . Please tell me how you think about this , otherwise i can do it in this pr as well !

Cool, looking forward to your next pr!

[liurenjie1024]

LGTM, thanks!

[hiirrxnn]

Since this PR hadn't been merged yet , the new changes in new PR contains both original issue changes and new ones . Please check that out and let me know if something has to be changed !

[Fokko]

Nice!

[Fokko]

I noticed that the CI is failing:

Caused by:
  TOML parse error at line 23, column 12
     |
  23 | homepage = {url = "https://rust.iceberg.apache.org/"}
     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  invalid type: map, expected a string

Suggested change

	homepage = {url = "https://rust.iceberg.apache.org/"}
	homepage = "https://rust.iceberg.apache.org/"

[hiirrxnn]

I have fixed this in the new PR , please review those changes and let me know if something has to be improved

[Xuanwo]

Thanks! It's better to run taplo fmt to format the toml files.

[Fokko]

I tried to resolve conflicts, but failed 😞

[liurenjie1024]

Seems duplicated with #160. How about we close this pr and focus on #160 only?

[liurenjie1024]

Thanks! It's better to run taplo fmt to format the toml files.

Good suggestion!