Skip to content

Commit

Permalink
fix: speficy the version of munge for msrv check (#987)
Browse files Browse the repository at this point in the history
#704 fail in msrv check and I find that's because `cargo update faststr`
will update the munge to `0.4.2` instead of `0.4.1`. The simple fix way
is to specify the precise version of munge. But I'm not sure whether
it's good practice here. Do you have any suggestions for this? cc
@Xuanwo @xxchan

Co-authored-by: ZENOTME <st810918843@gmail.com>
  • Loading branch information
ZENOTME and ZENOTME authored Feb 24, 2025
1 parent 1a2a8c8 commit 0c60c10
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,8 @@ jobs:
# Some dependencies don't correctly specify a minimal version for their dependencies and will fail to build.
# So we update these transitive dependencies here.
cargo update tap faststr metainfo linkedbytes
# munge 0.4.2 will cause fail to use 1.7.1 so specify the correct version here.
cargo update -p munge --precise 0.4.1
- name: Setup MSRV Rust toolchain
uses: ./.github/actions/setup-builder
with:
Expand Down

0 comments on commit 0c60c10

Please sign in to comment.