Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install poetry-shell-plugin #1673

Closed
wants to merge 1 commit into from
Closed

Conversation

gabeiglio
Copy link
Contributor

With the release of poetry version 2.0.1 the shell command will only be available through installing the poetry-plugin-shell: see

This PR makes sure to install this plugin along with poetry

@gabeiglio gabeiglio changed the title [INFRA] Install poetry-shell-plugin Install poetry-shell-plugin Feb 17, 2025
Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah seems like poetry shell is moved to the plugin. I dont see poetry shell used anywhere in the repo. And i typically just use poetry run ...

@gabeiglio what is your use case for this?

@gabeiglio
Copy link
Contributor Author

gabeiglio commented Feb 17, 2025

I usually follow this instruction from the docs to setup/activate the venv:

If you want to install the library on the host, you can simply run pip3 install -e .. If you wish to use a virtual environment, you can run poetry shell. Poetry will open up a virtual environment with all the dependencies set.

But, if other folks dont use this, then the docs could just point out that the shell needs to be installed separately

@kevinjqliu
Copy link
Contributor

oh interesting. yea i think its good to update the docs to optionally install poetry shell. I've always just used poetry run ... maybe we can add that to the docs too

@gabeiglio
Copy link
Contributor Author

Sounds good! Ill close this pr and open another one to update the docs

@gabeiglio gabeiglio closed this Feb 17, 2025
@gabeiglio gabeiglio deleted the poetryShell branch February 17, 2025 21:50
kevinjqliu pushed a commit that referenced this pull request Feb 18, 2025
More context [here](#1673) 

Wanted to keep it as short as possible
@kevinjqliu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants