Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove fields empty check #48

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

MichaelLeeHZ
Copy link
Contributor

Which issue does this PR close?

Closes #

Rationale for this change

Sometime there is no fields in a table, error occurs when data writing :

java.lang.IllegalArgumentException: Empty.fields
        at io.shaded.ceresdb.common.util.Requires.requireTrue(Requires.java:72)
        at io.shaded.ceresdb.models.Point$PointBuilder.check(Point.java:84)
        at io.shaded.ceresdb.models.Point$PointBuilder.build(Point.java:78)

What changes are included in this PR?

Remove fields empty check.

Are there any user-facing changes?

How does this change test

@CLAassistant
Copy link

CLAassistant commented Mar 3, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


MachaelLee seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@MichaelLeeHZ MichaelLeeHZ force-pushed the fix_fields_empty_error branch from ae3886b to 7e25031 Compare March 3, 2023 07:05
@MichaelLeeHZ MichaelLeeHZ reopened this Mar 3, 2023
Copy link
Contributor

@mrrtree mrrtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrrtree mrrtree merged commit c420443 into apache:main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants