Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 1.0.0 API #40

Merged
merged 20 commits into from
Feb 14, 2023
Merged

refactor: 1.0.0 API #40

merged 20 commits into from
Feb 14, 2023

Conversation

mrrtree
Copy link
Contributor

@mrrtree mrrtree commented Feb 7, 2023

Which issue does this PR close?

Closes #

Rationale for this change

What changes are included in this PR?

  • SDK refactor query/write API
  • Remove management client side, replaced by generic SqlQuery
  • CeresDBClient builder add required parameter RouteMode

Are there any user-facing changes?

same as changes

How does this change test

All unit test passed.
Complete data life process test passed.

@CLAassistant
Copy link

CLAassistant commented Feb 7, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ZuLiangWang
ZuLiangWang reviewed Feb 8, 2023
View reviewed changes
@mrrtree mrrtree changed the title Feat/refactor api refactor: refactor 1.0.0 api Feb 9, 2023
MichaelLeeHZ
MichaelLeeHZ reviewed Feb 9, 2023
View reviewed changes
MichaelLeeHZ
MichaelLeeHZ reviewed Feb 9, 2023
View reviewed changes
@mrrtree mrrtree force-pushed the feat/refactor_api branch 2 times, most recently from 817e92f to 9b19ac4 Compare February 9, 2023 09:23
@mrrtree mrrtree changed the title refactor: refactor 1.0.0 api refactor: 1.0.0 api Feb 10, 2023
@mrrtree mrrtree changed the title refactor: 1.0.0 api refactor: 1.0.0 API Feb 10, 2023
MichaelLeeHZ
MichaelLeeHZ previously approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@MichaelLeeHZ MichaelLeeHZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZuLiangWang
ZuLiangWang approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@ZuLiangWang ZuLiangWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZuLiangWang ZuLiangWang merged commit c0df97c into apache:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZuLiangWang ZuLiangWang ZuLiangWang approved these changes

@MichaelLeeHZ MichaelLeeHZ MichaelLeeHZ left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrrtree @CLAassistant @ZuLiangWang @MichaelLeeHZ