Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace inner repo maintained protos with ceresdbproto #36

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

archerny
Copy link
Contributor

Which issue does this PR close?

Closes #32

Rationale for this change

See the issue #32

What changes are included in this PR?

Proto definition files and auto generated Java codes are removed. Add a new dependency ceresdb-proto-internal

Are there any user-facing changes?

Real users are not influenced. Developers of this project are going to be influenced. In the future, all changes related to proto should be committed to ceresdbproto first.

How does this change test

Pass the existing CI.

Copy link
Contributor

@ZuLiangWang ZuLiangWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZuLiangWang ZuLiangWang merged commit 6fb27a7 into apache:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the protos and generated codes inside this project.
2 participants