Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make version more maintainable and change it to 0.1.0 #35

Merged
merged 3 commits into from
Jan 11, 2023

Conversation

archerny
Copy link
Contributor

@archerny archerny commented Jan 11, 2023

Which issue does this PR close?

No, it is just the chore before release.

Rationale for this change

The version field is scattered everywhere in the repo. The parent pom.xml and its children have their own version, however, in almost every case, they should be identical. Modifying all fields is tedious and error-prone work.

What changes are included in this PR?

Are there any user-facing changes?

Real users are not influenced. Developers of this project should take care of this PR. If you want to change the version field, just modify the property revision in parent pom, rather than modify all pom files. It was not convenient to maintain the version field before. Developers would forget to alter the version field in child pom.

How does this change test

Pass the existing CI.

@archerny archerny requested a review from ZuLiangWang January 11, 2023 04:08
Copy link
Contributor

@ZuLiangWang ZuLiangWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZuLiangWang ZuLiangWang merged commit 6505fec into apache:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants