Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update code formatter and its settings #18

Merged
merged 11 commits into from
Jul 25, 2022
Merged

fix: update code formatter and its settings #18

merged 11 commits into from
Jul 25, 2022

Conversation

archerny
Copy link
Contributor

Which issue does this PR close?

Closes #17

Rationale for this change

code formatter maven plugin and the eclipse code formatter settings.

What changes are included in this PR?

  1. replace the deprecated code formatter plugin with a new one
  2. modify some settings for eclipse code formatter
  3. add IDEA code format settings

Are there any user-facing changes?

see issue #17

How does this change test

pass the CI

@archerny archerny changed the title fix: update Code formatter and its settings fix: update code formatter and its settings Jul 25, 2022
jiacai2050
jiacai2050 approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@jiacai2050 jiacai2050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@archerny archerny merged commit 9db69b8 into apache:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiacai2050 jiacai2050 jiacai2050 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

code formatter settings does not work sometimes.
2 participants
@archerny @jiacai2050