Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid message mistakenly appended #46

Merged
merged 2 commits into from
Sep 12, 2023
Merged

fix: avoid message mistakenly appended #46

merged 2 commits into from
Sep 12, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Sep 12, 2023 •
edited
Loading

Rationale

Current implementation will append multiple error message together.

Detailed Changes

  • Fix broken CI, rename CeresdbError to Error.
  • Only append error message when old message is empty.

Test Plan

CI

ZuLiangWang
ZuLiangWang approved these changes Sep 12, 2023
View reviewed changes
Copy link

@ZuLiangWang ZuLiangWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 4b3fe8c into main Sep 12, 2023
@jiacai2050 jiacai2050 deleted the fix-err-message branch September 12, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZuLiangWang ZuLiangWang ZuLiangWang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiacai2050 @ZuLiangWang