Fix flaky test - testDisableErrorLogByDefault

[GrantPSpencer]

Issues

• My PR addresses the following Helix issues and references them in the PR description:

#2818
Flaky test currently failing in CI

Description

• Here are some details about my PR, including screenshots of any UI changes:

Test failing in CI but passes locally. Likely this is due to attempting to read ZK node immediately after calling calling .logError() . If ZK server on CI is slow, the node may not be created yet. We should use verifier instead to retry read and only assert that it is eventually created

Tests

• The following tests are written for this issue:

changed to using verifier in: TestStatusUpdateUtil.testEnableErrorLog

Changes that Break Backward Compatibility (Optional)

• My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:

N/A

Commits

• My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Code Quality

• My diff has been formatted using helix-style.xml
  (helix-style-intellij.xml if IntelliJ IDE is used)