Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-19449][table-planner] LEAD/LAG cannot work correctly in streaming mode #15793

Merged
merged 1 commit into from
Apr 28, 2021

Conversation

JingsongLi
Copy link
Contributor

Cherry-pick #15747

What is the purpose of the change

Fix "LEAD/LAG cannot work correctly in streaming mode".

LeadLagAggFunction is only works in batch mode with OffsetOverFrame.
In streaming mode, it will output wrong results.

Brief change log

  • Add LinkedListSerializer.
  • Fix wrong document for lead and lag.
  • Pass isBounded to AggFunctionFactory.
  • Implement LagAggFunction.
  • Add Lag IT Case for streaming mode.

Verifying this change

  • OverAggregateITCase.testLagFunction
  • OverAggregateITCase.testLeadFunction

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no) no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) no
  • The serializers: (yes / no / don't know) no
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know) no
  • The S3 file system connector: (yes / no / don't know) no

Documentation

  • Does this pull request introduce a new feature? (yes / no) no

@JingsongLi JingsongLi changed the base branch from master to release-1.13 April 28, 2021 06:51
@flinkbot
Copy link
Collaborator

flinkbot commented Apr 28, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 02fe863 (Fri May 28 11:05:23 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Apr 28, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

@cshuo
Copy link
Contributor

cshuo commented Apr 28, 2021

LGTM, +1

@JingsongLi JingsongLi merged commit c623db4 into apache:release-1.13 Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants