[FLINK-19449][table-planner] LEAD/LAG cannot work correctly in streaming mode #15747
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,163 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.table.planner.functions.aggfunctions; | ||
|
|
||
| import org.apache.flink.api.common.typeutils.TypeSerializer; | ||
| import org.apache.flink.table.api.DataTypes; | ||
| import org.apache.flink.table.api.TableException; | ||
| import org.apache.flink.table.functions.AggregateFunction; | ||
| import org.apache.flink.table.runtime.functions.aggregate.BuiltInAggregateFunction; | ||
| import org.apache.flink.table.runtime.typeutils.InternalSerializers; | ||
| import org.apache.flink.table.runtime.typeutils.LinkedListSerializer; | ||
| import org.apache.flink.table.types.DataType; | ||
| import org.apache.flink.table.types.logical.LogicalType; | ||
| import org.apache.flink.table.types.logical.LogicalTypeRoot; | ||
| import org.apache.flink.table.types.utils.DataTypeUtils; | ||
|
|
||
| import java.util.Arrays; | ||
| import java.util.LinkedList; | ||
| import java.util.List; | ||
| import java.util.Objects; | ||
|
|
||
| /** Lag {@link AggregateFunction}. */ | ||
| public class LagAggFunction<T> extends BuiltInAggregateFunction<T, LagAggFunction.LagAcc<T>> { | ||
|
|
||
| private final transient DataType[] valueDataTypes; | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| public LagAggFunction(LogicalType[] valueTypes) { | ||
| this.valueDataTypes = | ||
| Arrays.stream(valueTypes) | ||
| .map(DataTypeUtils::toInternalDataType) | ||
| .toArray(DataType[]::new); | ||
| if (valueDataTypes.length == 3 | ||
| && valueDataTypes[2].getLogicalType().getTypeRoot() != LogicalTypeRoot.NULL) { | ||
| if (valueDataTypes[0].getConversionClass() != valueDataTypes[2].getConversionClass()) { | ||
| throw new TableException( | ||
| String.format( | ||
| "Please explicitly cast default value %s to %s.", | ||
| valueDataTypes[2], valueDataTypes[1])); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // -------------------------------------------------------------------------------------------- | ||
| // Planning | ||
| // -------------------------------------------------------------------------------------------- | ||
|
|
||
| @Override | ||
| public List<DataType> getArgumentDataTypes() { | ||
| return Arrays.asList(valueDataTypes); | ||
| } | ||
|
|
||
| @Override | ||
| public DataType getAccumulatorDataType() { | ||
| return DataTypes.STRUCTURED( | ||
| LagAcc.class, | ||
| DataTypes.FIELD("offset", DataTypes.INT()), | ||
| DataTypes.FIELD("defaultValue", valueDataTypes[0]), | ||
| DataTypes.FIELD("buffer", getLinkedListType())); | ||
| } | ||
|
|
||
| @SuppressWarnings({"unchecked", "rawtypes"}) | ||
| private DataType getLinkedListType() { | ||
| TypeSerializer<T> serializer = | ||
| InternalSerializers.create(getOutputDataType().getLogicalType()); | ||
| return DataTypes.RAW( | ||
| LinkedList.class, (TypeSerializer) new LinkedListSerializer<>(serializer)); | ||
| } | ||
|
|
||
| @Override | ||
| public DataType getOutputDataType() { | ||
| return valueDataTypes[0]; | ||
| } | ||
|
|
||
| // -------------------------------------------------------------------------------------------- | ||
| // Runtime | ||
| // -------------------------------------------------------------------------------------------- | ||
|
|
||
| public void accumulate(LagAcc<T> acc, T value) throws Exception { | ||
| acc.buffer.add(value); | ||
| while (acc.buffer.size() > acc.offset + 1) { | ||
| acc.buffer.removeFirst(); | ||
| } | ||
| } | ||
|
|
||
| public void accumulate(LagAcc<T> acc, T value, int offset) throws Exception { | ||
| if (offset < 0) { | ||
| throw new TableException(String.format("Offset(%d) should be positive.", offset)); | ||
| } | ||
|
|
||
| acc.offset = offset; | ||
| accumulate(acc, value); | ||
| } | ||
|
|
||
| public void accumulate(LagAcc<T> acc, T value, int offset, T defaultValue) throws Exception { | ||
|
There was a problem hiding this comment. This method will invoke above method. |
||
| acc.defaultValue = defaultValue; | ||
| accumulate(acc, value, offset); | ||
| } | ||
|
|
||
| public void resetAccumulator(LagAcc<T> acc) throws Exception { | ||
| acc.offset = 1; | ||
| acc.defaultValue = null; | ||
| acc.buffer.clear(); | ||
| } | ||
|
|
||
| @Override | ||
| public T getValue(LagAcc<T> acc) { | ||
| if (acc.buffer.size() < acc.offset + 1) { | ||
| return acc.defaultValue; | ||
| } else if (acc.buffer.size() == acc.offset + 1) { | ||
| return acc.buffer.getFirst(); | ||
| } else { | ||
| throw new TableException("Too more elements: " + acc); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public LagAcc<T> createAccumulator() { | ||
| return new LagAcc<>(); | ||
| } | ||
|
|
||
| /** Accumulator for LAG. */ | ||
| public static class LagAcc<T> { | ||
| public int offset = 1; | ||
| public T defaultValue = null; | ||
| public LinkedList<T> buffer = new LinkedList<>(); | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (o == null || getClass() != o.getClass()) { | ||
| return false; | ||
| } | ||
| LagAcc<?> lagAcc = (LagAcc<?>) o; | ||
| return offset == lagAcc.offset | ||
| && Objects.equals(defaultValue, lagAcc.defaultValue) | ||
| && Objects.equals(buffer, lagAcc.buffer); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return Objects.hash(offset, defaultValue, buffer); | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better validating offset > -1 and giving some meaningful exception message.