-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-20387][table] Support TIMESTAMP_LTZ as rowtime attribute #15485
[FLINK-20387][table] Support TIMESTAMP_LTZ as rowtime attribute #15485
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 2803f76 (Fri May 28 09:01:57 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work @leonardBang , I left some comments.
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/TableSchema.java
Outdated
Show resolved
Hide resolved
...table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeChecks.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/flink/table/runtime/operators/rank/window/combines/TopNRecordsCombiner.java
Outdated
Show resolved
Hide resolved
...in/java/org/apache/flink/table/runtime/operators/window/triggers/ProcessingTimeTriggers.java
Outdated
Show resolved
Hide resolved
...ble-runtime-blink/src/main/java/org/apache/flink/table/runtime/typeutils/TypeCheckUtils.java
Outdated
Show resolved
Hide resolved
.../src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/MatchRecognizeITCase.scala
Show resolved
Hide resolved
...k/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TimeAttributeITCase.scala
Outdated
Show resolved
Hide resolved
...-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/UnionTest.scala
Outdated
Show resolved
Hide resolved
...flink-table-api-java/src/main/java/org/apache/flink/table/catalog/DefaultSchemaResolver.java
Outdated
Show resolved
Hide resolved
...flink-table-api-java/src/main/java/org/apache/flink/table/catalog/DefaultSchemaResolver.java
Outdated
Show resolved
Hide resolved
f805a55
to
99f1c41
Compare
99f1c41
to
2b01969
Compare
...flink-table-api-java/src/main/java/org/apache/flink/table/catalog/DefaultSchemaResolver.java
Outdated
Show resolved
Hide resolved
...flink-table-api-java/src/main/java/org/apache/flink/table/catalog/DefaultSchemaResolver.java
Outdated
Show resolved
Hide resolved
...table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeChecks.java
Outdated
Show resolved
Hide resolved
...table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeChecks.java
Outdated
Show resolved
Hide resolved
...he/flink/table/runtime/operators/aggregate/window/processors/AbstractWindowAggProcessor.java
Outdated
Show resolved
Hide resolved
...-blink/src/main/scala/org/apache/flink/table/planner/calcite/RelTimeIndicatorConverter.scala
Outdated
Show resolved
Hide resolved
...-blink/src/main/scala/org/apache/flink/table/planner/calcite/RelTimeIndicatorConverter.scala
Outdated
Show resolved
Hide resolved
...-blink/src/main/scala/org/apache/flink/table/planner/calcite/RelTimeIndicatorConverter.scala
Outdated
Show resolved
Hide resolved
...-blink/src/main/scala/org/apache/flink/table/planner/calcite/RelTimeIndicatorConverter.scala
Outdated
Show resolved
Hide resolved
...-blink/src/main/scala/org/apache/flink/table/planner/calcite/RelTimeIndicatorConverter.scala
Outdated
Show resolved
Hide resolved
2b01969
to
ee69df7
Compare
ee69df7
to
0870141
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some final comments.
...a/org/apache/flink/table/runtime/operators/aggregate/window/buffers/RecordsWindowBuffer.java
Outdated
Show resolved
Hide resolved
...a/org/apache/flink/table/runtime/operators/aggregate/window/buffers/RecordsWindowBuffer.java
Outdated
Show resolved
Hide resolved
...he/flink/table/runtime/operators/aggregate/window/processors/AbstractWindowAggProcessor.java
Outdated
Show resolved
Hide resolved
...he/flink/table/runtime/operators/aggregate/window/processors/AbstractWindowAggProcessor.java
Outdated
Show resolved
Hide resolved
...org/apache/flink/table/runtime/operators/aggregate/window/LocalSlicingWindowAggOperator.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/flink/table/runtime/operators/rank/window/processors/WindowRankProcessor.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/flink/table/runtime/operators/window/triggers/EventTimeTriggers.java
Outdated
Show resolved
Hide resolved
9827fa7
to
2a7b885
Compare
2a7b885
to
2803f76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
the failed test is not relate to this PR, it has reported in FLINK-22122 |
Merging... |
What is the purpose of the change
Brief change log
Verifying this change
Add plan, operator, IT test to cover the change.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation
will be documented and add to release notes