Address comments

apache · Apr 25, 2021 · 4a1f9d1 · 4a1f9d1
1 parent c153cf7
commit 4a1f9d1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/...k/src/main/java/org/apache/flink/table/planner/functions/aggfunctions/LagAggFunction.java b/...k/src/main/java/org/apache/flink/table/planner/functions/aggfunctions/LagAggFunction.java
@@ -100,6 +100,10 @@ public void accumulate(LagAcc<T> acc, T value) throws Exception {
     }
 
     public void accumulate(LagAcc<T> acc, T value, int offset) throws Exception {
+        if (offset < 0) {
+            throw new TableException(String.format("Offset(%d) should be positive.", offset));
+        }
+
         acc.offset = offset;
         accumulate(acc, value);
     }

diff --git a/...r-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/AggFunctionFactory.scala b/...r-blink/src/main/scala/org/apache/flink/table/planner/plan/utils/AggFunctionFactory.scala
@@ -45,9 +45,10 @@ import scala.collection.JavaConversions._
  * as subclasses of [[SqlAggFunction]] in Calcite but not as [[BridgingSqlAggFunction]]. The factory
  * returns [[DeclarativeAggregateFunction]] or [[BuiltInAggregateFunction]].
  *
- * @param inputType the input rel data type
- * @param orderKeyIdx the indexes of order key (null when is not over agg)
- * @param needRetraction true if need retraction
+ * @param inputRowType the input row type
+ * @param orderKeyIndexes the indexes of order key (null when is not over agg)
+ * @param aggCallNeedRetractions true if need retraction
+ * @param isBounded true if the source is bounded source
  */
 class AggFunctionFactory(
     inputRowType: RowType,