Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36923] Bump flink version to 1.20.0, adapt CI workflow #54

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

lvyanquan
Copy link
Contributor

Bump flink version to 1.19.1 to support Flink 1.20

Copy link

boring-cyborg bot commented Dec 18, 2024

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@lvyanquan lvyanquan changed the title [FLINK-FLINK-36923] Bump flink version to 1.19.1, adapt CI workflow [FLINK-36923] Bump flink version to 1.19.1, adapt CI workflow Dec 18, 2024
@lvyanquan
Copy link
Contributor Author

Hi @ferenc-csaky

Could you help to review this? and I would greatly appreciate it if you could share your thoughts on this bump plan and the next release.

@ferenc-csaky
Copy link
Contributor

Hi, thanks for your contribution! I am planning to try to include at least JDK 17 (and possibly 21) support for the next release, which will require to bump HBase version and pretty much all Hadoop related dependencies. I spent some time on that before releasing 4.0, but it is not trivial and I ran into some runtime issues, that's where I decided to cut scope and release to only JDK8 and 11.

Including these version updates makes sense anyway, so I do not see a problem merging it on its own.

Copy link
Contributor

@ferenc-csaky ferenc-csaky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove 1.18 from the CI workflows.

@lvyanquan lvyanquan changed the title [FLINK-36923] Bump flink version to 1.19.1, adapt CI workflow [FLINK-36923] Bump flink version to 1.20.0, adapt CI workflow Dec 22, 2024
@ferenc-csaky
Copy link
Contributor

@lvyanquan Any specific reason to remove 1.19 as well? I am not necessarily against it, but since 1.19 is still supported I believe it would make sense to go with 1.19, 1.20 support as the default setup if there are no other things to consider. WDYT?

@lvyanquan
Copy link
Contributor Author

Hi, @ferenc-csaky.

The reason of directly bumping to 1.20 is because I want to speed up the adaptation to 1.20 and try to start integrating with Flink 2.0, and we've released flink-connector-hbase 4.0.0 that supported Flink 1.18 & Flink 1.19, so we can release a 4.0.1 for bug fix in Flink 1.19.

However, this is not a mandatory requirement for me, so I also want to confirm with you whether this is feasible.
If this is too radical, I will revert back to bumping 1.19 and support both 1.19 and 1.20.

@ferenc-csaky ferenc-csaky merged commit 7e7d74b into apache:main Jan 9, 2025
3 checks passed
Copy link

boring-cyborg bot commented Jan 9, 2025

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants