-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-33440] Update Flink version matrix, add 1.19-SNAPSHOT to GH workflows, update flink-connector-parent #35
Conversation
I guess we should also update the |
shoukd we wait a bit since currently 1.16.3 and 1.17.2 are in voting phase and then add all three? |
Yeah, that makes sense. 👍 |
1f10397
to
f6f9fa0
Compare
There was snappy update, probably need to add explicit dependency to cope with |
We need to decide how to resolve the Guava dependency convergence: we can't pin the latest version, since that misses classes that are required by HBase. Perhaps we should bump HBase in general? |
Sorry for the late answer. There were already a discussion about dropping HBase 1.x back in the day before I started the externalization: https://lists.apache.org/thread/x7l2gj8g93r4v6x6953cyt6jrs8c4r1b I am okay with dropping it, probably the sooner the better, as it would reduce the complexity of the conenctor a lot, although for 1.18.0 it is not necessary, these dep changes are required for 1.19. @MartijnVisser @snuyanzin WDYT? |
3741bfe
to
642ae01
Compare
@MartijnVisser pinning the older Guava also works, AFAIK externalized connectors are not necessary to depend on the |
@ferenc-csaky Will you rebase this PR? I'll close #39 |
Yes, will do. |
…rkflows, update flink-connector-parent
9db2d22
to
5ef9dfa
Compare
@MartijnVisser updated the version matrix, PTAL. Removed the 1.18.0 run for the |
@snuyanzin I fixed the dep convergence for 1.19 the last CI run failed on, also had to change |
cc @MartijnVisser