Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-33440] Update Flink version matrix, add 1.19-SNAPSHOT to GH workflows, update flink-connector-parent #35

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

ferenc-csaky
Copy link
Contributor

@ferenc-csaky
Copy link
Contributor Author

I guess we should also update the v3.0 branch, or since there were a couple features added since that would it make sense to create a v3.1 and release that against Flink 1.18?

@snuyanzin
Copy link
Contributor

shoukd we wait a bit since currently 1.16.3 and 1.17.2 are in voting phase and then add all three?

@ferenc-csaky
Copy link
Contributor Author

shoukd we wait a bit since currently 1.16.3 and 1.17.2 are in voting phase and then add all three?

Yeah, that makes sense. 👍

@ferenc-csaky ferenc-csaky changed the title [FLINK-33440] Add Flink 1.18.0 and 1.19-SNAPSHOT to GH workflows [FLINK-33440] Update Flink version matrix, add 1.18.0 and 1.19-SNAPSHOT to GH workflows Dec 4, 2023
@ferenc-csaky
Copy link
Contributor Author

cc @MartijnVisser @snuyanzin

@snuyanzin
Copy link
Contributor

There was snappy update, probably need to add explicit dependency to cope with
https://github.com/apache/flink-connector-hbase/actions/runs/7085132836/job/19876358681?pr=35#step:14:78

@MartijnVisser
Copy link
Contributor

We need to decide how to resolve the Guava dependency convergence: we can't pin the latest version, since that misses classes that are required by HBase. Perhaps we should bump HBase in general?

@ferenc-csaky
Copy link
Contributor Author

We need to decide how to resolve the Guava dependency convergence: we can't pin the latest version, since that misses classes that are required by HBase. Perhaps we should bump HBase in general?

Sorry for the late answer. There were already a discussion about dropping HBase 1.x back in the day before I started the externalization: https://lists.apache.org/thread/x7l2gj8g93r4v6x6953cyt6jrs8c4r1b

I am okay with dropping it, probably the sooner the better, as it would reduce the complexity of the conenctor a lot, although for 1.18.0 it is not necessary, these dep changes are required for 1.19.

@MartijnVisser @snuyanzin WDYT?

@ferenc-csaky
Copy link
Contributor Author

@MartijnVisser pinning the older Guava also works, AFAIK externalized connectors are not necessary to depend on the flink-shaded Guava. I am pro removing HBase 1 though, but according to my point that may not blocks this change.

@MartijnVisser
Copy link
Contributor

@ferenc-csaky Will you rebase this PR? I'll close #39

@ferenc-csaky
Copy link
Contributor Author

@ferenc-csaky Will you rebase this PR? I'll close #39

Yes, will do.

@ferenc-csaky ferenc-csaky changed the title [FLINK-33440] Update Flink version matrix, add 1.18.0 and 1.19-SNAPSHOT to GH workflows [FLINK-33440] Update Flink version matrix, add 1.19-SNAPSHOT to GH workflows, update flink-connector-parent Mar 20, 2024
@ferenc-csaky
Copy link
Contributor Author

@MartijnVisser updated the version matrix, PTAL.

Removed the 1.18.0 run for the v3.0 branch, as it was not released for Flink 1.18. My understanding is that would require a v3.1, right?

@ferenc-csaky
Copy link
Contributor Author

@snuyanzin I fixed the dep convergence for 1.19 the last CI run failed on, also had to change HBaseTablePlanTest as the JUnit5 migration for TableTestBase in the core repo in 1.19 required some adaptation. Can you retrigger another run pls?

@snuyanzin snuyanzin merged commit 08b7b69 into apache:main Apr 16, 2024
9 checks passed
@ferenc-csaky ferenc-csaky deleted the FLINK-33440 branch April 17, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants