[Issue #718] update Grpc Message Model name to SimpleMessage #723

jinrongluo · 2022-01-18T15:41:05Z

Fixes ISSUE #718

Motivation

update Grpc Message Model name to SimpleMessage

Modifications

sync the commits from master branch
update Grpc Message Model name to SimpleMessage
update the Grpc documentation

…port procotol

1. Add Metrics plugin module 2. Implement opentelemetry metrics module related issue apache#696

* add docs * change default spanExporter to span

Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>

docs/cn/instructions/eventmesh-runtime-protocol.md

docs/cn/instructions/eventmesh-runtime-quickstart-with-docker.md

docs/cn/instructions/eventmesh-sdk-java-quickstart.md

docs/en/instructions/eventmesh-sdk-java-quickstart.md

…comments

…t-Reply API

xwm1992 · 2022-02-02T03:20:00Z

please fix the conflicts thanks. @jinrongluo

eventmesh-examples/src/main/java/org/apache/eventmesh/grpc/sub/CloudEventsSubscribeReply.java

eventmesh-examples/src/main/java/org/apache/eventmesh/grpc/sub/EventmeshSubscribeReply.java

xwm1992 · 2022-02-02T03:35:49Z

If all the changes has been done, you can leave a notification and I'll do the whole test again thanks. @jinrongluo

jinrongluo · 2022-02-02T17:44:46Z

hi @xwm1992 I still need to run more testing in myself. I will let you know when I done. thanks.

# Conflicts: # docs/cn/instructions/eventmesh-sdk-java-quickstart.md # docs/en/instructions/eventmesh-sdk-java-quickstart.md

jinrongluo · 2022-02-03T21:34:12Z

please fix the conflicts thanks. @jinrongluo

Merge conflict is fixed.

jinrongluo · 2022-02-03T21:36:31Z

@xwm1992 I have completed the development and testing of this PR. Please go ahead and run more testing at your end. Thanks. for the review.

xwm1992 · 2022-02-04T09:29:04Z

I run the AsyncPublishInstance and EventmeshAsyncSubscribe under the grpc module, got following error:

Received Server side error: INTERNAL: gRPC frame header malformed: reserved bits not zero.

After got this error, the client has been shutted down and only got one message, but the topic offset has been updated to 5, this phenomenon is reasonable ?

this error is not inevitable, please take a look, thanks.
@jinrongluo

jinrongluo · 2022-02-04T14:33:28Z

Hi @xwm1992 I am not able to reproduce this error in my development environment. How are you running this test?

Please make sure you use the right Publisher and Subscriber as shown below. Thanks.

xwm1992 · 2022-02-09T11:31:22Z

Hi, @jinrongluo if I run the AsyncPublishInstance first, then run the EventMeshAsyncSubscribe this may reproduce the error mentioned above, and for server side got the error below:

Receive error from client: CANCELLED: cancelled before receiving half close
StreamObserver Error onCompleted. CANCELLED: call already cancelled
(Http2ConnectionHandler.java:911) - [id: 0xdffacbb2, L:/127.0.0.1:10205 - R:/127.0.0.1:51069] Sent GOAWAY: lastStreamId '3', errorCode '2', debugData 'Stream 3 sent too many headers EOS: false'. Forcing shutdown of the connection.

jinrongluo · 2022-02-09T21:14:34Z

I run the AsyncPublishInstance and EventmeshAsyncSubscribe under the grpc module, got following error:

Received Server side error: INTERNAL: gRPC frame header malformed: reserved bits not zero.

After got this error, the client has been shutted down and only got one message, but the topic offset has been updated to 5, this phenomenon is reasonable ?

this error is not inevitable, please take a look, thanks. @jinrongluo

Thanks @xwm1992 The root cause of this issue is that Grpc StreamObserver is not thread safe. The Java doc is here:
https://grpc.github.io/grpc-java/javadoc/io/grpc/stub/StreamObserver.html

Since individual StreamObservers are not thread-safe, if multiple threads will be writing to a StreamObserver concurrently, the application must synchronize calls.

The fix is in this commit - 48ab8d3

vongosling · 2022-02-10T06:37:11Z

I will merge to branch, we could continue review, test and bugfix. @jinrongluo @qqeasonchen

jinrongluo and others added 13 commits January 12, 2022 17:39

[Issue apache#417] Create getting started instructions for Grpc trans…

96306f7

…port procotol

[Issue apache#533] Adding design doc for EventMesh Workflow

e8e481b

[ISSUE apache#696] Add metrics plugin (apache#709)

6cfa401

1. Add Metrics plugin module 2. Implement opentelemetry metrics module related issue apache#696

[ISSUE apache#713] Fix trace bug (apache#712)

96dd89a

* add docs * change default spanExporter to span

[Issue apache#553] update the design doc.

dd73a41

small updates to doc

3763f0b

Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>

small update

222bf40

Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>

adding asyncapi type to event defs

335271c

Signed-off-by: Tihomir Surdilovic <tihomir@temporal.io>

Remove unnecessary call toString (apache#719)

d751188

[Issue apache#553] add workflow diagram to the design doc

c971a76

Update intro.md (apache#722)

d26c558

Update roadmap.md (apache#721)

bf7559a

[Issue apache#417] update Grpc Message Model name to SimpleMessage

802b010

jinrongluo changed the title ~~[Issue #417] update Grpc Message Model name to SimpleMessage~~ [Issue #418] update Grpc Message Model name to SimpleMessage Jan 18, 2022

jinrongluo changed the title ~~[Issue #418] update Grpc Message Model name to SimpleMessage~~ [Issue #718] update Grpc Message Model name to SimpleMessage Jan 18, 2022

jinrongluo mentioned this pull request Jan 18, 2022

[Question] Some questions in grpc feature #718

Closed

1 task

[Issue apache#417] more update Grpc Message Model name to SimpleMessage

f0d1b8a

xwm1992 added this to the 1.4.0 milestone Jan 19, 2022

ruanwenjun reviewed Jan 19, 2022

View reviewed changes

docs/cn/instructions/eventmesh-runtime-protocol.md Show resolved Hide resolved

vongosling reviewed Jan 24, 2022

View reviewed changes

docs/cn/instructions/eventmesh-runtime-quickstart-with-docker.md Outdated Show resolved Hide resolved

docs/cn/instructions/eventmesh-sdk-java-quickstart.md Outdated Show resolved Hide resolved

vongosling reviewed Jan 24, 2022

View reviewed changes

docs/en/instructions/eventmesh-sdk-java-quickstart.md Outdated Show resolved Hide resolved

jinrongluo added 9 commits January 25, 2022 10:24

[Issue apache#718] Fix readme file and protobuf file based on review …

dad432e

…comments

[Issue apache#745] fix the ack bugs and cloudevent message resolver

025eb2e

[Issue apache#744] update SDK API message model

97b3d8a

[Issue apache#744] fix the gRPC Consumer SubscribeStream Message handler

0ad24d7

[Issue apache#744] Grpc Request-Reply API support

2d84469

[Issue apache#744] Bug fix for Grpc Request-Reply API support

495a67e

[Issue apache#744] minor fix for Grpc request-Reply API

e1c75a8

[Issue apache#744] fix infinte message loop in Grpc CloudEvent reques…

fceb1d8

…t-Reply API

[Issue apache#744] Fix Grpc subscribe-unsubscribe bug

0450346

[Issue apache#744] Fix Data models in Grpc Request-Reply API

7d05921

xwm1992 requested changes Feb 2, 2022

View reviewed changes

eventmesh-examples/src/main/java/org/apache/eventmesh/grpc/sub/CloudEventsSubscribeReply.java Outdated Show resolved Hide resolved

eventmesh-examples/src/main/java/org/apache/eventmesh/grpc/sub/EventmeshSubscribeReply.java Outdated Show resolved Hide resolved

jinrongluo added 3 commits February 2, 2022 16:31

[Issue apache#744] Code optimization for Grpc Request-Reply API

2e085d8

[Issue apache#417] support Grpc broadcast async publish

137497f

Merge remote-tracking branch 'upstream/grpc' into grpc

0213180

# Conflicts: # docs/cn/instructions/eventmesh-sdk-java-quickstart.md # docs/en/instructions/eventmesh-sdk-java-quickstart.md

[Issue apache#718] add synchronized calls for grpc streamObserver

48ab8d3

vongosling merged commit 7332d24 into apache:grpc Feb 10, 2022

jinrongluo mentioned this pull request Feb 10, 2022

[Bug] Using Request-Reply mode timeout with grpc #744

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Issue #718] update Grpc Message Model name to SimpleMessage #723

[Issue #718] update Grpc Message Model name to SimpleMessage #723

jinrongluo commented Jan 18, 2022 •

edited

Loading

xwm1992 commented Feb 2, 2022

xwm1992 commented Feb 2, 2022

jinrongluo commented Feb 2, 2022

jinrongluo commented Feb 3, 2022

jinrongluo commented Feb 3, 2022

xwm1992 commented Feb 4, 2022 •

edited

Loading

jinrongluo commented Feb 4, 2022

xwm1992 commented Feb 9, 2022 •

edited

Loading

jinrongluo commented Feb 9, 2022 •

edited

Loading

vongosling commented Feb 10, 2022

[Issue #718] update Grpc Message Model name to SimpleMessage #723

[Issue #718] update Grpc Message Model name to SimpleMessage #723

Conversation

jinrongluo commented Jan 18, 2022 • edited Loading

Motivation

Modifications

xwm1992 commented Feb 2, 2022

xwm1992 commented Feb 2, 2022

jinrongluo commented Feb 2, 2022

jinrongluo commented Feb 3, 2022

jinrongluo commented Feb 3, 2022

xwm1992 commented Feb 4, 2022 • edited Loading

jinrongluo commented Feb 4, 2022

xwm1992 commented Feb 9, 2022 • edited Loading

jinrongluo commented Feb 9, 2022 • edited Loading

vongosling commented Feb 10, 2022

jinrongluo commented Jan 18, 2022 •

edited

Loading

xwm1992 commented Feb 4, 2022 •

edited

Loading

xwm1992 commented Feb 9, 2022 •

edited

Loading

jinrongluo commented Feb 9, 2022 •

edited

Loading