Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #340]Integrate With OpenTelemetry #464

Closed
wants to merge 8 commits into from
Closed

[ISSUE #340]Integrate With OpenTelemetry #464

wants to merge 8 commits into from

Conversation

Roc-00
Copy link
Contributor

@Roc-00 Roc-00 commented Jul 25, 2021

Fixes ISSUE#<340>.

Motivation

Export metrics data with open telemetry and use Prometheus for visual observation

Modifications

There is a readme document in the code I submitted. I use idea to run locally. I download Prometheus in the window version of the official website. The operation method of docker written in readme is given by reference to open telemetry. I haven't actually operated it. I was successful in running locally. I'm not sure whether the code I wrote meets the requirements, so I didn't finish all the metrics, but wrote three. If there is anything wrong, please put it forward and I will modify and improve it. When the code is perfect and correct, I will continue to write the rest of the code.

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented?README.md

@Roc-00
Copy link
Contributor Author

Roc-00 commented Jul 25, 2021

It seems that I did something wrong with PR operation... I have brought up the previous pr. how can I solve it?

@codecov-commenter
Copy link

Codecov Report

Merging #464 (091516f) into develop (4eaebde) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop    #464   +/-   ##
=========================================
  Coverage       9.84%   9.84%           
  Complexity       283     283           
=========================================
  Files            228     228           
  Lines          10829   10829           
  Branches         923     923           
=========================================
  Hits            1066    1066           
  Misses          9666    9666           
  Partials          97      97           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eaebde...091516f. Read the comment docs.

@ruanwenjun
Copy link
Member

It seems that I did something wrong with PR operation... I have brought up the previous pr. how can I solve it?

@Roc-00 What do you mean? If this pr was submitted accidentally, then you can close it. If you have chosen the wrong branch, then you can edit this pr.

BTW, there already seems to be some interest in this issue #340, if you want to deal with it, you would better describe your plan before submit a pr.

@Roc-00
Copy link
Contributor Author

Roc-00 commented Jul 25, 2021

It seems that I did something wrong with PR operation... I have brought up the previous pr. how can I solve it?

@Roc-00 What do you mean? If this pr was submitted accidentally, then you can close it. If you have chosen the wrong branch, then you can edit this pr.

BTW, there already seems to be some interest in this issue #340, if you want to deal with it, you would better describe your plan before submit a pr.

image
I'm not sure if I have submitted what I want to submit, because I click in and don't find the content of my file. If the person you mentioned is tydhot, I have asked him for advice.

@Roc-00 Roc-00 closed this Jul 25, 2021
@ruanwenjun
Copy link
Member

@Roc-00 You can discuss in this issue #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants